-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixel: update link styles #6517
Conversation
3426206
to
2518972
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
} | ||
} | ||
}, | ||
"core/post-content": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the Figma, links inside post content should be italicized in :active, :focus:, :hover states. I added a config for that here, but I noticed that it broke the block margins even though it should be a valid config:
Any idea why? I will investigate and open a bug report upstream if needed, but we may need to find a workaround in the meantime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reported here: WordPress/gutenberg#43955
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a workaround added explicit spacing -> blockGap
in post-content
to fix the issue.
38cd784
to
71b168c
Compare
71b168c
to
a73ec55
Compare
@jffng This behaviour is achieved using additional css. It is now matching figma. @beafialho @henriqueiamarino can you confirm if it is expected to have different default styling for categories and tags? |
Figma is updated @madhusudhand... Categories and Tags follow the same styling. |
Changes proposed in this Pull Request:
Pagination:
Related issue(s):
Fixes: #6456