Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel: update link styles #6517

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Pixel: update link styles #6517

merged 4 commits into from
Sep 8, 2022

Conversation

madhusudhand
Copy link
Member

Changes proposed in this Pull Request:

block/state default hover active focus
link image image image image
site-title image image image image
post-title image image image image

Pagination:
image

Related issue(s):

Fixes: #6456

@madhusudhand madhusudhand self-assigned this Sep 7, 2022
@madhusudhand madhusudhand changed the title update theme link styles Pixel: update link styles Sep 7, 2022
@jffng jffng force-pushed the pixel/link-styles branch from 3426206 to 2518972 Compare September 7, 2022 14:25
Copy link
Contributor

@jffng jffng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Figma, category links in the post list do not have underlines:

Screen Shot 2022-09-07 at 10 35 53 AM

It seems inconsistent but wanted to confirm.

}
}
},
"core/post-content": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the Figma, links inside post content should be italicized in :active, :focus:, :hover states. I added a config for that here, but I noticed that it broke the block margins even though it should be a valid config:

Screen Shot 2022-09-07 at 10 39 28 AM

Any idea why? I will investigate and open a bug report upstream if needed, but we may need to find a workaround in the meantime.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported here: WordPress/gutenberg#43955

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a workaround added explicit spacing -> blockGap in post-content to fix the issue.

@madhusudhand
Copy link
Member Author

In the Figma, category links in the post list do not have underlines:

Screen Shot 2022-09-07 at 10 35 53 AM

It seems inconsistent but wanted to confirm.

@jffng This behaviour is achieved using additional css. It is now matching figma.

@beafialho @henriqueiamarino can you confirm if it is expected to have different default styling for categories and tags?

@henriqueiamarino
Copy link
Collaborator

Figma is updated @madhusudhand... Categories and Tags follow the same styling.

@jffng jffng merged commit 1e7f989 into trunk Sep 8, 2022
@jffng jffng deleted the pixel/link-styles branch September 8, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pixel: Styles: Links
3 participants