Pixel: update navigation menu #6509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jffng
reviewed
Sep 6, 2022
pixel/theme.json
Outdated
| "spacing": { | ||
| "blockGap": "1rem", | ||
| "padding": { | ||
| "left": "0.5rem !important", |
There was a problem hiding this comment.
Is the important is necessary because the root padding values end up overriding the spacing that is set on the block? Is that a bug, or expected?
There was a problem hiding this comment.
Without it, navigation inherits root padding leaving more space on the right. adding !important to gain higher specificity.
Created an issue here: WordPress/gutenberg#43931
madhusudhand
force-pushed
the
pixel/navigation
branch
from
dd6641e to
8123c41
Compare
Link styles are addressed here. #6517 |
jffng
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Updated site-title font family
Navigation on large screens
Navigation on small screens
Related issue(s):
Fixes: #6460