Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Search Results pattern #4168

Closed
wants to merge 1 commit into from
Closed

i18n: Search Results pattern #4168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 2 additions & 19 deletions quadrat/block-templates/search.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,5 @@
<!-- wp:template-part {"slug":"header"} /-->

<!-- wp:group {"layout":{"inherit":true}, "className":"page-content"} -->
<div class="wp-block-group page-content">
<!-- wp:pattern {"slug":"quadrat/search-results"} /-->

<!-- wp:heading -->
<h2>Results:</h2>
<!-- /wp:heading -->

<!-- wp:query {"queryId":1,"query":{"perPage":10,"pages":0,"offset":0,"postType":"post","categoryIds":[],"tagIds":[],"order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":true}} -->
<!-- wp:query-loop -->

<!-- wp:post-title {"level":5,"isLink":true} /-->
<!-- wp:post-excerpt /-->

<!-- /wp:query-loop -->
<!-- /wp:query -->

</div>
<!-- /wp:group -->

<!-- wp:template-part {"slug":"footer"} /-->
<!-- wp:template-part {"slug":"footer"} /-->
1 change: 1 addition & 0 deletions quadrat/inc/block-patterns.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ function quadrat_register_block_patterns() {
'latest-episodes',
'listen-to-the-podcast',
'media-text-button',
'search-results',
);

if ( class_exists( 'WP_Block_Type_Registry' ) && \WP_Block_Type_Registry::get_instance()->is_registered( 'jetpack/subscriptions' ) ) {
Expand Down
29 changes: 29 additions & 0 deletions quadrat/inc/patterns/search-results.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php
/**
* Search results
*
* @package Quadrat
*/

return array(
'title' => __( 'Search results', 'quadrat' ),
'categories' => array( 'quadrat' ),
'content' => '<!-- wp:group {"layout":{"inherit":true}, "className":"page-content"} -->
<div class="wp-block-group page-content">

<!-- wp:heading -->
<h2>' . __('Results') . ':</h2>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is tangent to the question of the Pattern block, but the colon should be a part of the string, allowing translators to localise accordingly:

Suggested change
<h2>' . __('Results') . ':</h2>
<h2>' . __('Results:') . '</h2>

This is a boon for languages that follow different punctuation conventions (e.g. alternatives to the colon, or spacing prescriptions around the colon), but also — I expect, without having tested — a way to avoid flow bugs manifesting in RTL languages.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, TIL :)

<!-- /wp:heading -->

<!-- wp:query {"queryId":1,"query":{"perPage":10,"pages":0,"offset":0,"postType":"post","categoryIds":[],"tagIds":[],"order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":true}} -->
<!-- wp:query-loop -->

<!-- wp:post-title {"level":5,"isLink":true} /-->
<!-- wp:post-excerpt /-->

<!-- /wp:query-loop -->
<!-- /wp:query -->

</div>
<!-- /wp:group -->',
);