i18n: Search Results pattern #4168
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
scruffian
force-pushed
the
add/search-pattern
branch
2 times, most recently
from
4204354 to
75fcbc8
Compare
mcsf
reviewed
Jul 15, 2021
| <div class="wp-block-group page-content"> | ||
|
|
||
| <!-- wp:heading --> | ||
| <h2>' . __('Results') . ':</h2> |
There was a problem hiding this comment.
This is tangent to the question of the Pattern block, but the colon should be a part of the string, allowing translators to localise accordingly:
Suggested change
| <h2>' . __('Results') . ':</h2> | |
| <h2>' . __('Results:') . '</h2> |
This is a boon for languages that follow different punctuation conventions (e.g. alternatives to the colon, or spacing prescriptions around the colon), but also — I expect, without having tested — a way to avoid flow bugs manifesting in RTL languages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is for testing WordPress/gutenberg#33217
Related issue(s):
#3653