Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: segmentation criteria for subscriptions and memberships #1230

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Oct 13, 2023

All Submissions:

Changes proposed in this Pull Request:

Registers the new subscriptions and memberships criteria implemented in Automattic/newspack-plugin#2696. Also stealth-fixes a warning that I was seeing in the Newspack_Popups_Inserter class.

How to test the changes in this Pull Request:

Follow testing instructions in Automattic/newspack-plugin#2696. I put testing instructions there because most of the logic for handling the reader data and giving meaning to the criteria lives there.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Oct 13, 2023
@dkoo dkoo marked this pull request as ready for review October 13, 2023 23:04
@dkoo dkoo requested a review from a team as a code owner October 13, 2023 23:04
Copy link
Member

@adekbadek adekbadek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stealth-fixes a warning

It's not stealth if you mention it in the description!

@dkoo dkoo merged commit bef21e0 into master Oct 26, 2023
2 checks passed
@dkoo dkoo deleted the feat/product-ownership-criteria branch October 26, 2023 10:12
matticbot pushed a commit that referenced this pull request Oct 31, 2023
# [2.26.0-alpha.1](v2.25.0...v2.26.0-alpha.1) (2023-10-31)

### Features

* segmentation criteria for subscriptions and memberships ([#1230](#1230)) ([bef21e0](bef21e0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.26.0-alpha.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

matticbot pushed a commit that referenced this pull request Nov 13, 2023
# [2.26.0](v2.25.0...v2.26.0) (2023-11-13)

### Features

* segmentation criteria for subscriptions and memberships ([#1230](#1230)) ([bef21e0](bef21e0))
@matticbot
Copy link
Contributor

🎉 This PR is included in version 2.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants