-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: segmentation criteria for subscriptions and memberships #2696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some non-blocking comments.
Also in 6b26f57, I fixed (hopefully for the last time) a style error in the positioning of the loading spinner for the |
# [2.11.0-alpha.1](v2.10.0...v2.11.0-alpha.1) (2023-10-31) ### Features * **donations:** process after-checkout-button params ([167a20e](167a20e)) * **recaptcha:** make recaptcha threshold configurable ([#2705](#2705)) ([f3ec1a6](f3ec1a6)) * segmentation criteria for subscriptions and memberships ([#2696](#2696)) ([4631b51](4631b51))
🎉 This PR is included in version 2.11.0-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
# [2.11.0](v2.10.3...v2.11.0) (2023-11-13) ### Bug Fixes * get subscriptions from any order type ([#2744](#2744)) ([5f0bef3](5f0bef3)) ### Features * add donation processing filters ([#2720](#2720)) ([d041fa8](d041fa8)) * **donations:** process after-checkout-button params ([167a20e](167a20e)) * **emails:** support billing name on receipt email ([#2729](#2729)) ([c9ad368](c9ad368)) * **modal-checkout:** allow covering Stripe's fees ([#2695](#2695)) ([420ca32](420ca32)) * new options for Stripe fees ([#2745](#2745)) ([c974352](c974352)) * **recaptcha:** make recaptcha threshold configurable ([#2705](#2705)) ([f3ec1a6](f3ec1a6)) * remove MC4WP from managed plugins ([#2723](#2723)) ([8026688](8026688)) * segmentation criteria for subscriptions and memberships ([#2696](#2696)) ([4631b51](4631b51)) * **stripe-migration:** support mapping of products by SKU ([#2725](#2725)) ([08f9569](08f9569))
🎉 This PR is included in version 2.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
All Submissions:
Changes proposed in this Pull Request:
Along with Automattic/newspack-popups#1230, adds support and UI for two new sets of criteria, based on subscriptions and memberships.
Also splits the UI for the single segment screen into smaller subsections, as the current set of sections was looking crowded as we add more criteria. (cc @thomasguillot)
Note that I moved some files around and renamed some others for consistency.
ListsControl
component is only used in the context of the Campaigns wizard, so I moved it out of the Newspack Components directory and into the components for the wizard. Also made this more abstract so it could be reused for all of thelist__in
andlist__not_in
criteria.CamelCase
tokebab-case
, which matches most of our file naming across repos. Didn't try to be exhaustive about this.AutocompleteTokenfield
component, to make the placement of the spinner component during loading more consistent and predictable.Closes
1205451924709229/1205603536115944
.How to test the changes in this Pull Request:
master
, register two new user accounts in separate sessions. On Account A, purchase a non-donation subscription product. On Account B, join any membership plan by satisfying the plan's requirements for granting access.Other information: