-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: match thankyou template when using existing customer email #1550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
4d20fee adds an extra security layer using Woo's |
## [1.75.4](v1.75.3...v1.75.4) (2023-10-10) ### Bug Fixes * match thankyou template when using existing customer email ([#1550](#1550)) ([4b0dbf2](4b0dbf2))
🎉 This PR is included in version 1.75.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Introduced here (#1550 (comment)), but if the key and order are not valid, this template will not be rendered at all.
Introduced here (#1550 (comment)), but if the key and order are not valid, this template will not be rendered at all.
## [1.75.6](v1.75.5...v1.75.6) (2023-10-19) ### Bug Fixes * hide WC's login prompt ([124fee7](124fee7)) * **modal-checkout:** remove login prompt from initial flow ([4a8d48f](4a8d48f)), closes [/github.com//pull/1550#issuecomment-1755996086](https://github.com//github.com/Automattic/newspack-blocks/pull/1550/issues/issuecomment-1755996086)
# [2.0.0-alpha.2](v2.0.0-alpha.1...v2.0.0-alpha.2) (2023-10-19) ### Bug Fixes * hide WC's login prompt ([124fee7](124fee7)) * **modal-checkout:** remove login prompt from initial flow ([4a8d48f](4a8d48f)), closes [/github.com//pull/1550#issuecomment-1755996086](https://github.com//github.com/Automattic/newspack-blocks/pull/1550/issues/issuecomment-1755996086)
All Submissions:
Changes proposed in this Pull Request:
Adjusts some logic in the WooCommerce checkout flow when using the modal checkout. In the scenario where a donation is made while logged out but using an email address that's already associated with a custom account, we don't want to show the login prompt on the thank you step—instead, we want to show the order summary like we do for new email addresses or when already logged in.
How to test the changes in this Pull Request:
release
, while not logged in, make a donation using an email address that's already associated with an existing reader account.Other information: