Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add thankyou hook to custom form-login template #1555

Closed
wants to merge 1 commit into from

Conversation

dkoo
Copy link
Contributor

@dkoo dkoo commented Oct 14, 2023

All Submissions:

Changes proposed in this Pull Request:

#1550 implemented a custom form-login template that shows the regular "thank you" template order summary even when completing a transaction with an already-registered email address. #1521 added an optional redirect button to the regular thank you template. This PR adds the custom hook required to show the redirect button on the custom form-login template.

How to test the changes in this Pull Request:

  1. Follow instructions in feat: add option for a button after checkout #1521 to add a redirect button to a Checkout Button block.
  2. Complete a transaction using the Checkout Button, using an email address that's already registered with your test site.
  3. On master, observe that the redirect button is not shown.
  4. On this PR, confirm it is shown.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran tests with your changes locally?

@dkoo dkoo self-assigned this Oct 14, 2023
@dkoo dkoo requested a review from a team as a code owner October 14, 2023 05:31
@adekbadek
Copy link
Member

Note: these changes will be made obsolete if #1561 is merged.

@adekbadek
Copy link
Member

Closing, since #1561 fixes it among other changes.

@adekbadek adekbadek closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants