Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress.com Block Editor: do not use in the upcoming Block-based Widgets Editor #20358

Merged
merged 1 commit into from
Jul 14, 2021
Merged

WordPress.com Block Editor: do not use in the upcoming Block-based Widgets Editor #20358

merged 1 commit into from
Jul 14, 2021

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Jul 14, 2021 •
edited
Loading

Related: #20357

Changes proposed in this Pull Request:

Since the WordPress.com Block editor relies on wp-editor, and since that dependency cannot be used in the widget editor (see https://core.trac.wordpress.org/changeset/51393 ), let's not load the WordPress.com editor scripts in the widget editor.

Jetpack product discussion

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

  • Start from a site where Jetpack is connected to WordPress.com and where you are running WordPress 5.8 RC.
  • Go to Appearance > Widgets.
  • The wpcom-block-editor scripts should not be enqueued.

@jeherve
wpcom Block Editor: do not use in the Block-based Widgets Editor
0830fa7 
Fixes #20357

Since the WordPress.com Block editor relies on wp-editor, and since that dependency cannot be used in the widget editor (see https://core.trac.wordpress.org/changeset/51393 ), let's not load the WordPress.com editor scripts in the widget editor.
@jeherve jeherve added this to the jetpack/9.9.1 milestone Jul 14, 2021
@jeherve jeherve self-assigned this Jul 14, 2021
@jeherve jeherve requested a review from sdixon194 July 14, 2021 14:33
@github-actions github-actions bot added the [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ label Jul 14, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2021 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Jetpack plugin:

  • Next scheduled release: July 20, 2021.
  • Scheduled code freeze: July 15, 2021.

@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] In Progress labels Jul 14, 2021
@jeherve
Copy link
Member Author

jeherve commented Jul 14, 2021

Putting this on hold because it will not be enough to fix the original notice.

Discussion: p1626276335270600-slack-C01U2KGS2PQ

@jeherve jeherve added [Status] Blocked / Hold and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. labels Jul 14, 2021
@jeherve jeherve mentioned this pull request Jul 14, 2021
Open
2 tasks
@jeherve jeherve added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. and removed [Status] Blocked / Hold labels Jul 14, 2021
@jeherve
Copy link
Member Author

jeherve commented Jul 14, 2021

Putting this back under review, since while it won't remove the notice entirely, it will address the part the WordPress.com Block editor plays into the main issue.

sdixon194
sdixon194 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@sdixon194 sdixon194 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, wpcom-block-editor-default-editor-script doesn't get enqueued.

@sdixon194 sdixon194 merged commit b40a137 into master Jul 14, 2021
@sdixon194 sdixon194 deleted the fix/widget-wpcom-block-editor branch July 14, 2021 17:40
sdixon194 pushed a commit that referenced this pull request Jul 14, 2021
@jeherve @sdixon194
[not verified] WordPress.com Block Editor: do not use in the upcoming…
e51e782 
… Block-based Widgets Editor (#20358)

Fixes #20357

Since the WordPress.com Block editor relies on wp-editor, and since that dependency cannot be used in the widget editor (see https://core.trac.wordpress.org/changeset/51393 ), let's not load the WordPress.com editor scripts in the widget editor.
@sdixon194
Copy link
Contributor

Cherry picked to release branch in e51e782

@sdixon194 sdixon194 removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Needs Cherry-Pick labels Jul 14, 2021
jwebbdev pushed a commit that referenced this pull request Jul 14, 2021
@jeherve @jwebbdev
WordPress.com Block Editor: do not use in the upcoming Block-based Wi…
27c6c57 
…dgets Editor (#20358)

Fixes #20357

Since the WordPress.com Block editor relies on wp-editor, and since that dependency cannot be used in the widget editor (see https://core.trac.wordpress.org/changeset/51393 ), let's not load the WordPress.com editor scripts in the widget editor.
@danielbachhuber danielbachhuber mentioned this pull request Feb 15, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdixon194 sdixon194 sdixon194 approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] WordPress.com Block Editor [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
jetpack/9.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jeherve @sdixon194