Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AT Sites: Justify option for Paragraph blocks not available in Widget sections #66474

Open
ClassicRKR27 opened this issue Aug 10, 2022 · 7 comments
Labels
[Platform] Atomic [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@ClassicRKR27
Copy link

Quick summary

A user noticed that the justify option for the paragraph blocks wasn't showing when they were adding the block to any of their widgets sections. After some investigation I found that this is only affecting AT sites with classic themes (I've been able to replicate it consistently across multiple themes).

Steps to reproduce

  1. Activate a Classic Theme on an AT site
  2. Go to the widgets section and add a paragraph block into any of those sections
  3. Try to justify the text

What you expected to happen

The justify option should be available.

What actually happened

The justify option is non-existent (see images below):

Simple Site:

Screen Shot 2022-08-10 at 16 35 50

AT Site:

Screen Shot 2022-08-10 at 16 32 55

Context

Discovered the bug while working with this user: 36415641-hc

Platform (Simple, Atomic, or both?)

Atomic

Theme-specific issue?

No response

Browser, operating system and other notes

No response

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, easy to implement

Workaround details

The only way around this would be to use CSS to specifically target those areas as far as I can tell.

@ClassicRKR27 ClassicRKR27 added [Type] Bug User Report This issue was created following a WordPress customer report labels Aug 10, 2022
@github-actions github-actions bot added [Platform] Atomic [Pri] Normal Schedule for the next available opportuinity. labels Aug 10, 2022
@cuemarie
Copy link

cuemarie commented Aug 17, 2022

📌 SCRUBBING

  • Tested on Simple : Not Replicated
  • Tested on AT : Replicated
  • Tested on Self-hosted : Replicated
  • Replicable on Core - Yes - Edit: No, not a Core issue. 9/14

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Thanks for the clear report! I replicated issue on both AT and Self-Hosted sites using theme Twenty Twenty-One.
  • In AT and Self-Hosted environments, the Paragraph Block in a widget area lacked both a Justify and an Underline tool.
  • Simple sites do offer both of these tools.

AT SITE

Screen Shot 2022-08-16 at 7 05 12 PM

SELF-HOSTED SITE

Screen Shot 2022-08-16 at 7 06 43 PM

SIMPLE SITE FOR COMPARISON

Screen Shot 2022-08-16 at 7 04 13 PM

📌 ACTIONS

@cuemarie cuemarie added the Triaged To be used when issues have been triaged. label Aug 17, 2022
@cuemarie
Copy link

Returning to this after an update on the Gutenberg report WordPress/gutenberg#43292 (comment) :

Justify and Underline aren't formatting options in WordPress core

📌 ACTIONS

  • Removing from HE Cross-repo Watchlist

@danielbachhuber danielbachhuber self-assigned this Feb 9, 2023
@danielbachhuber
Copy link
Contributor

danielbachhuber commented Feb 15, 2023

Ugh, this is a deep rabbit hole 🙃

The Justify option appears on Simple sites, but doesn't appear for Atomic sites:

Simple Atomic
image image

The Justify option is added via this code:

registerFormatType( 'wpcom/justify', {
title: wpcomGutenberg.richTextToolbar.justify,
tagName: 'p',
className: null,
edit: ConnectedRichTextJustifyButton,
} );

Gutenberg has a forever issue open about adding Justify support: WordPress/gutenberg#8450 (comment)

WordPress.com went ahead and added it based on user feedback: #28696

In Jetpack, wpcom-block-editor depends on wp-editor. There was some conflict, so it was disabled for the widgets screen: Automattic/jetpack#20358. This has a forever open issue too: Automattic/jetpack#20357

As it turns out, I ran into this error five days ago: Automattic/jetpack#28867 (review)

We don't have the problem on WPCOM because the editor code is loaded differently fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Scyhtvaf%2Sthgraoret%2Qjcpbz%2Svaqrk.cuc%3Se%3Qnoo95n66%2326-og

It wasn't quite fully removed two years ago p9oQ9f-Ht-p2

@danielbachhuber
Copy link
Contributor

Asked about simply adding Justify to Gutenberg at this point p1676504822772359-slack-C45SNKV4Z

@danielbachhuber
Copy link
Contributor

danielbachhuber commented Feb 16, 2023

Opened a PR to add Justify to Gutenberg WordPress/gutenberg#48146

@jeherve Assuming the Gutenberg PR lands, at what point would we want to remove the corresponding code from Jetpack? After a stable WordPress release with the Justify option, or even further than that?

Here's an issue to handle the removal #73455

@jeherve
Copy link
Member

jeherve commented Feb 17, 2023

After a stable WordPress release with the Justify option, or even further than that?

Since the WordPress.com block editor is only loaded on WordPress.com (simple and WoA), we do not have to wait until a stable release; we should be able to remove it as soon as the new version of Gutenberg is updated on WordPress.com.

@sejas sejas removed their assignment Apr 5, 2024
@sejas
Copy link
Member

sejas commented Apr 5, 2024

I unassigned me from WordPress/gutenberg#48202, #73455, and from this issue, since I won't focus on it in the short term. Thank you!

These issues belong to a PT we didn't start pesfPa-rl-p2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Platform] Atomic [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Development

No branches or pull requests

5 participants