-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AT Sites: Justify option for Paragraph blocks not available in Widget sections #66474
Comments
📌 SCRUBBING
📌 FINDINGS/SCREENSHOTS/VIDEO
AT SITE SELF-HOSTED SITE SIMPLE SITE FOR COMPARISON 📌 ACTIONS
|
Returning to this after an update on the Gutenberg report WordPress/gutenberg#43292 (comment) :
📌 ACTIONS
|
Ugh, this is a deep rabbit hole 🙃 The Justify option appears on Simple sites, but doesn't appear for Atomic sites:
The Justify option is added via this code: wp-calypso/apps/wpcom-block-editor/src/default/features/rich-text.js Lines 73 to 78 in 669b13b
Gutenberg has a forever issue open about adding Justify support: WordPress/gutenberg#8450 (comment) WordPress.com went ahead and added it based on user feedback: #28696 In Jetpack, As it turns out, I ran into this error five days ago: Automattic/jetpack#28867 (review) We don't have the problem on WPCOM because the editor code is loaded differently fbhepr%2Skers%2Sjcpbz%2Sjc%2Qpbagrag%2Scyhtvaf%2Sthgraoret%2Qjcpbz%2Svaqrk.cuc%3Se%3Qnoo95n66%2326-og It wasn't quite fully removed two years ago p9oQ9f-Ht-p2 |
Asked about simply adding Justify to Gutenberg at this point p1676504822772359-slack-C45SNKV4Z |
Opened a PR to add Justify to Gutenberg WordPress/gutenberg#48146 @jeherve Assuming the Gutenberg PR lands, at what point would we want to remove the corresponding code from Jetpack? After a stable WordPress release with the Justify option, or even further than that? Here's an issue to handle the removal #73455 |
Since the WordPress.com block editor is only loaded on WordPress.com (simple and WoA), we do not have to wait until a stable release; we should be able to remove it as soon as the new version of Gutenberg is updated on WordPress.com. |
I unassigned me from WordPress/gutenberg#48202, #73455, and from this issue, since I won't focus on it in the short term. Thank you! These issues belong to a PT we didn't start pesfPa-rl-p2 |
Quick summary
A user noticed that the
justify
option for theparagraph
blocks wasn't showing when they were adding the block to any of theirwidgets
sections. After some investigation I found that this is only affecting AT sites with classic themes (I've been able to replicate it consistently across multiple themes).Steps to reproduce
paragraph
block into any of those sectionsWhat you expected to happen
The
justify
option should be available.What actually happened
The
justify
option is non-existent (see images below):Simple Site:
AT Site:
Context
Discovered the bug while working with this user: 36415641-hc
Platform (Simple, Atomic, or both?)
Atomic
Theme-specific issue?
No response
Browser, operating system and other notes
No response
Reproducibility
Consistent
Severity
All
Available workarounds?
Yes, easy to implement
Workaround details
The only way around this would be to use CSS to specifically target those areas as far as I can tell.
The text was updated successfully, but these errors were encountered: