-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHB24] Backgrounds and Feats #276
base: phb2024
Are you sure you want to change the base?
Conversation
added !ID_INTERNAL_GRANTS_BACKGROUND_ASI requirement to prevent doubled asi selection when using 2024 backgrounds
I haven't look at all the way through these yet, but the background ASI grant comes from the background so that it can replace the racial ASIs. With how the backgrounds are implemented now, the background ASIs are removed when the grant is given. |
No, the background ASIs are not removed when the grant is given, it's the contrary. When the grant is given, each background uses its own +2,+1/+1,+1,+1 ASIs (that is restricted to only 3 predetermined abilities) appended at the end of each file. When the grant is not given (using any backgrounds other than phb2024 ones) it uses the racial ASIs.. |
Ah, alright, my mistake |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a few corrections needed during my app testing. Two instances of PHB14 proficiency grants, a few typos, and a couple incorrect skill prof grants.
4a26cf5
to
1383977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some typos and corrections I found when testing the latest pulls.
Co-authored-by: tregolani <[email protected]>
Co-authored-by: tregolani <[email protected]>
Co-authored-by: tregolani <[email protected]>
No description provided.