Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHB24] Backgrounds and Feats #276

Open
wants to merge 30 commits into
base: phb2024
Choose a base branch
from

Conversation

Tel0k
Copy link

@Tel0k Tel0k commented Sep 16, 2024

No description provided.

added !ID_INTERNAL_GRANTS_BACKGROUND_ASI requirement to prevent doubled asi selection when using 2024 backgrounds
@FreshRoyal
Copy link
Contributor

I haven't look at all the way through these yet, but the background ASI grant comes from the background so that it can replace the racial ASIs. With how the backgrounds are implemented now, the background ASIs are removed when the grant is given.

@Tel0k
Copy link
Author

Tel0k commented Sep 16, 2024

No, the background ASIs are not removed when the grant is given, it's the contrary. When the grant is given, each background uses its own +2,+1/+1,+1,+1 ASIs (that is restricted to only 3 predetermined abilities) appended at the end of each file. When the grant is not given (using any backgrounds other than phb2024 ones) it uses the racial ASIs..

@FreshRoyal
Copy link
Contributor

Ah, alright, my mistake

@kgirtxd kgirtxd linked an issue Oct 30, 2024 that may be closed by this pull request
@tregolani
Copy link

Do we want to add setters for the short description in Aurora? Currently they're just blanks, which looks a bit strange when compared to backgrounds from other sources.
image

Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a few corrections needed during my app testing. Two instances of PHB14 proficiency grants, a few typos, and a couple incorrect skill prof grants.

@Tel0k Tel0k changed the title [PHB24] Backgrounds [PHB24] Backgrounds and Feats Nov 24, 2024
Copy link

@tregolani tregolani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some typos and corrections I found when testing the latest pulls.

core/players-handbook-2024/feats/feats-fighting-styles.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-fighting-styles.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-fighting-styles.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-fighting-styles.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-fighting-styles.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-general.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-general.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-epic-boons.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-epic-boons.xml Outdated Show resolved Hide resolved
core/players-handbook-2024/feats/feats-fighting-styles.xml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backgrounds
3 participants