Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: tregolani <[email protected]>
  • Loading branch information
Tel0k and tregolani authored Nov 20, 2024
1 parent 09414b1 commit 4a26cf5
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions core/players-handbook-2024/backgrounds/background-acolyte.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
<p>You devoted yourself to service in a temple, either nestled in a town or secluded in a sacred grove. There you performed rites in honor of a god or pantheon. You served under a priest and studied religion. Thanks to your priest’s instruction and your own devotion, you also learned how to channel a modicum of divine power in service to your place of worship and the people who prayed there.</p>
</description>
<rules>
<grant type="Proficiency" id="ID_PROFICIENCY_SKILL_INSIGHT" />
<grant type="Proficiency" id="ID_PROFICIENCY_SKILL_RELIGION" />
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_INSIGHT" />
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_RELIGION" />
<grant type="Grants" id="ID_INTERNAL_GRANTS_BACKGROUND_ASI" />
<!-- <grant type="Feat" id="_________" /> -->
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_CALLIGRAPHERS_SUPPLIES" />
Expand Down
4 changes: 2 additions & 2 deletions core/players-handbook-2024/backgrounds/background-farmer.xml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
<p>You grew up close to the land. Years tending animals and cultivating the earth rewarded you with patience and good health. You have a keen appreciation for nature's bounty alongside a healthy respect for nature's wrath.</p>
</description>
<rules>
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_SLEIGHTOFHAND" />
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_STEALTH" />
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_ANIMALHANDLING" />
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_NATURE" />
<grant type="Grants" id="ID_INTERNAL_GRANTS_BACKGROUND_ASI" /> <!--
<grant type="Feat" id="_________" />-->
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_TOOL_PROFICIENCY_CARPENTERS_TOOLS" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<table>
<tr><td><b>Ability Scores:</b></td><td> Strength, Dexterity, Wisdom</td></tr>
<tr><td><b>Feat:</b> </td><td> Tavern Brawler (see chapter 5)</td></tr>
<tr><td><b>Skill Proficiencies:</b></td><td> : Acrobatics and Perception</td></tr>
<tr><td><b>Skill Proficiencies:</b></td><td> Acrobatics and Perception</td></tr>
<tr><td><b>Tool Proficiency:</b></td><td> Navigator's Tools</td></tr>
<tr><td><b>Equipment:</b></td><td> <i>Choose A or B:</i> (A) Dagger, Navigator's Tools, Rope, Traveler’s Clothes, 20 GP; or (B) 50 GP</td></tr>
</table>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<table>
<tr><td><b>Ability Scores:</b></td><td> Dexterity, Intelligence, Wisdom</td></tr>
<tr><td><b>Feat:</b> </td><td> Skilled (see chapter 5)</td></tr>
<tr><td><b>Skill Proficiencies:</b></td><td> : Investigation and Perception</td></tr>
<tr><td><b>Skill Proficiencies:</b></td><td> Investigation and Perception</td></tr>
<tr><td><b>Tool Proficiency:</b></td><td> Calligrapher’s Supplies</td></tr>
<tr><td><b>Equipment:</b></td><td> <i>Choose A or B:</i> (A) Calligrapher's Supplies, Fine Clothes, Lamp, Oil (3 flasks). Parchment (12 sheets), 23 GP; or (B) 50 GP</td></tr>
</table>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
</description>
<rules>
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_ATHLETICS" />
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_PERCEPTION" />
<grant type="Proficiency" id="ID_WOTC_PHB24_PROFICIENCY_SKILL_INTIMIDATION" />
<grant type="Grants" id="ID_INTERNAL_GRANTS_BACKGROUND_ASI" /> <!--
<grant type="Feat" id="_________" />-->
<select type="Proficiency" name="Gaming Set (Soldier)" supports="Gaming Set" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<table>
<tr><td><b>Ability Scores:</b></td><td> Dexterity, Wisdom, Charisma</td></tr>
<tr><td><b>Feat:</b> </td><td> Lucky (see chapter 5)</td></tr>
<tr><td><b>Skill Proficiencies:</b></td><td> : Insight and Stealth</td></tr>
<tr><td><b>Skill Proficiencies:</b></td><td> Insight and Stealth</td></tr>
<tr><td><b>Tool Proficiency:</b></td><td> Thieves' Tools</td></tr>
<tr><td><b>Equipment:</b></td><td> <i>Choose A or B:</i> (A) 2 Daggers, Thieves' Tools, Gaming Set (any), Bedroll, 2 Pouches, Traveler's Clothes, 16 GP; or (B) 50 GP</td></tr>
</table>
Expand Down

0 comments on commit 4a26cf5

Please sign in to comment.