Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbus identities #1259

Merged
merged 6 commits into from
Jun 5, 2023
Merged

Dbus identities #1259

merged 6 commits into from
Jun 5, 2023

Conversation

bublath
Copy link
Contributor

@bublath bublath commented Jun 4, 2023

Sorry to reopen an new PR - git still is a mystery to me sometimes and rebasing/merging code isn't working out as expected.
This PR should adress all your concerns and hints.

I'm sure there is still room for improvement.
Once we finalized this, I'll update the documentation as well of course.

@AsamK
Copy link
Owner

AsamK commented Jun 4, 2023

The interface look good 👍

@bublath
Copy link
Contributor Author

bublath commented Jun 5, 2023

Added the documentation. While doing that I realized that case sensitivity was different from Devices and Groups, so I updated that as well.

One additional idea: it would be nice to give a similar capability as the App to display your own safety number along with a QR code, so you could establish trust both ways. Any hint how to get that and how to make a QR out of it?
(for device links I have been using https://chart.googleapis.com/chart?cht=qr&chs=200x200&chl=.)

Once we're done I probably should create one clean commit for this to clean up the mess I created when messing with git

@AsamK
Copy link
Owner

AsamK commented Jun 5, 2023

One additional idea: it would be nice to give a similar capability as the App to display your own safety number along with a QR code, so you could establish trust both ways. Any hint how to get that and how to make a QR out of it? (for device links I have been using https://chart.googleapis.com/chart?cht=qr&chs=200x200&chl=.)

There's no such thing as your own safety numbers anymore. The safety number of a contact is created from the contact's private key and your own private key. So the same safety numbers will be displayed on both sides.
The QR code is created from the scannableSafetyNumber, I think you need to convert the base64 number to byte array and then to a string using latin1(?) Encoding and create the qr code from that.

Once we're done I probably should create one clean commit for this to clean up the mess I created when messing with git

I'll just squash the pr when merging, that's just a button click in GitHub.

@bublath
Copy link
Contributor Author

bublath commented Jun 5, 2023

Sounds good. I need to try that QR stuff at some point, but that's independant of this PR.
I did some tests with this code and all looks like expected.
Let me know if there are more changes requires - otherwise I would consider this done.

Copy link
Owner

@AsamK AsamK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@AsamK AsamK merged commit a96c493 into AsamK:master Jun 5, 2023
@bublath bublath deleted the dbus_identities branch June 5, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants