-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dbus identities #1259
Dbus identities #1259
Conversation
The interface look good 👍 |
Co-authored-by: Sebastian Scheibner <[email protected]>
Added the documentation. While doing that I realized that case sensitivity was different from Devices and Groups, so I updated that as well. One additional idea: it would be nice to give a similar capability as the App to display your own safety number along with a QR code, so you could establish trust both ways. Any hint how to get that and how to make a QR out of it? Once we're done I probably should create one clean commit for this to clean up the mess I created when messing with git |
There's no such thing as your own safety numbers anymore. The safety number of a contact is created from the contact's private key and your own private key. So the same safety numbers will be displayed on both sides.
I'll just squash the pr when merging, that's just a button click in GitHub. |
Sounds good. I need to try that QR stuff at some point, but that's independant of this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
Sorry to reopen an new PR - git still is a mystery to me sometimes and rebasing/merging code isn't working out as expected.
This PR should adress all your concerns and hints.
I'm sure there is still room for improvement.
Once we finalized this, I'll update the documentation as well of course.