Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbus methods: listIdentity, trust #728

Closed
wants to merge 3 commits into from

Conversation

johnfreed
Copy link
Contributor

@johnfreed johnfreed commented Sep 21, 2021

Implement new Dbus methods:

  • listIdentity(number<s>)
  • trust(number<s>, safetyNumber<s>)

Update documentation

Implement new Dbus methods:
- listIdentity(number<s>)
- trust(number<s>, safetyNumber<s>)

Update documentation
src/main/java/org/asamk/Signal.java Outdated Show resolved Hide resolved

Exceptions: AttachmentInvalid, Failure, InvalidNumber, UntrustedIdentity
getGroupMembers(groupId<ay>) -> members<as>::
getGroupMembers(base64GroupId<s>) -> members<as>::
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unrelated doc changes here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

    rename listIdentity to listIdentities and more closely follow
behavior of the listIdentities command

    update documentation

    respond to issues raised by AsamK in initial pull request
@johnfreed
Copy link
Contributor Author

I took another approach to this one to more closely mirror the listIdentities command, and so I used that name.

Calling with an argument (a single contact) returns a dictionary just for that contact, with the contact number as key and the four data points as values.

Calling without an argument returns an array of dictionaries of all relevant contacts with the four data points. (Perhaps that should be instead a single dictionary with multiple keys?)

@johnfreed
Copy link
Contributor Author

I think I'll resubmit it as a single dictionary with multiple keys.

Now returns a complete dictionary (array of dictionary entries) rather
then a list of one-entry dictionaries.
@bublath
Copy link
Contributor

bublath commented Mar 29, 2023

Any chance that this gets continued? A dbus interface to restore trust is the top requirement my users would still have, as they currently have to do this from commandline, instead of using my User Interface.

@AsamK
Copy link
Owner

AsamK commented Jun 5, 2023

Superseded by #1259

@AsamK AsamK closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants