-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding IMU data in AP_DDS library for high frequency raw imu data transmission #26187
Conversation
7cab4be
to
f6900c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM. Looks like you followed the pattern well and populated the covariance in accordance with the docs.
b6654ea
to
d593fc9
Compare
the commit list needs needs a big cleanup |
note that this will get the 1st IMU, if you want the active IMU then you need to call AP_AHRS::_get_primary_gyro_index(), otherwise if you get a lane change then you will get noisy data |
0216e70
to
f1fce9d
Compare
875077b
to
f399c2a
Compare
f399c2a
to
d5e4d19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting close! Just a few fixes and it should be good to go.
Here's the data it captured on my system.
---
header:
stamp:
sec: 7
nanosec: 632779000
frame_id: base_link_ned
orientation:
x: 0.9851087927818298
y: 6.668890273431316e-05
z: -1.8647700926521793e-05
w: -0.17193196713924408
orientation_covariance:
- -1.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
angular_velocity:
x: 5.1383547543082386e-05
y: 0.0001419413456460461
z: 5.413950566435233e-05
angular_velocity_covariance:
- -1.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
linear_acceleration:
x: -0.0013561300002038479
y: -0.001497147954069078
z: -9.81856632232666
linear_acceleration_covariance:
- -1.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
- 0.0
---
* Using NED frame
Looks great. I cleaned up your commits with |
This code enables imu data transmission between ros2 nodes and AP via DDS. @Ryanf55 please review this and suggest changes.