Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check for all number cases in writer in optionValueConverter #14331

Conversation

standeren
Copy link
Contributor

Description

Check for all number cases in writer in optionValueConverter

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes backend team/studio-domain1 skip-documentation Issues where updating documentation is not relevant labels Dec 23, 2024
@standeren standeren linked an issue Dec 23, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. quality/testing Tests that are missing, needs to be created or could be improved. labels Dec 23, 2024
Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (1aa8bb1) to head (ed4a257).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14331   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files        1841     1841           
  Lines       23880    23880           
  Branches     2755     2755           
=======================================
  Hits        22823    22823           
  Misses        800      800           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErlingHauan ErlingHauan self-assigned this Jan 2, 2025
Copy link
Contributor

@ErlingHauan ErlingHauan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Since the scope of this PR is small, I tested it as well, and it works great 👍

@ErlingHauan ErlingHauan added the skip-manual-testing PRs that do not need to be tested manually label Jan 2, 2025
@ErlingHauan ErlingHauan merged commit 0c3d521 into main Jan 2, 2025
16 checks passed
@ErlingHauan ErlingHauan deleted the 14290-type-issue-in-backend-when-editing-a-code-list-with-numbers branch January 2, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend quality/testing Tests that are missing, needs to be created or could be improved. skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Type issue in backend when editing a code list with numbers
2 participants