-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check for all number cases in writer in optionValueConverter #14331
fix: check for all number cases in writer in optionValueConverter #14331
Conversation
…ode-list-with-numbers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14331 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 1841 1841
Lines 23880 23880
Branches 2755 2755
=======================================
Hits 22823 22823
Misses 800 800
Partials 257 257 ☔ View full report in Codecov by Sentry. |
…ode-list-with-numbers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! Since the scope of this PR is small, I tested it as well, and it works great 👍
…ode-list-with-numbers
Description
Check for all number cases in writer in optionValueConverter
Related Issue(s)
Verification