Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove full reload of Preview (v4) #12534

Merged
merged 48 commits into from
Apr 5, 2024
Merged

Remove full reload of Preview (v4) #12534

merged 48 commits into from
Apr 5, 2024

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Mar 18, 2024 •
edited
Loading

Description

  • Moved useSearchParamsState into shared
  • Removed layout from localStorage
  • Removed duplicated code by creating three new hooks: useSelectedFormLayoutName, useSelectedFormLayoutSetName and useSelectedTaskid

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Mar 18, 2024
This was linked to issues Mar 18, 2024
Texts are not updated in Preview #12519
Closed
Adding / Deleting / Changing order of pages does not reflect in Preview #12535
Closed
Unintended Behavior: Excessive Backend Saves on Each Keypress in Edit Component-ID #11989
Open
Selecting a new page does not reflect in Preview (only with v4) #12539
Closed
@framitdavid framitdavid mentioned this pull request Mar 20, 2024
Closed
@mlqn mlqn linked an issue Mar 20, 2024 that may be closed by this pull request
Remove Redux from the forms editor package #10500
Closed
@github-actions github-actions bot added the area/dashboard Area: Related to the dashboard application label Mar 20, 2024
@github-actions github-actions bot added the kind/dependencies Used for issues or pull requests that are dependency updates label Mar 21, 2024
@mlqn mlqn marked this pull request as draft March 25, 2024 21:20
@mlqn mlqn removed a link to an issue Mar 26, 2024
Unintended Behavior: Excessive Backend Saves on Each Keypress in Edit Component-ID #11989
Open
@mlqn mlqn changed the title Remove full reload of Preview Remove full reload of Preview (v4) Mar 26, 2024
@mlqn mlqn marked this pull request as ready for review March 27, 2024 07:46
@mlqn mlqn linked an issue Apr 1, 2024 that may be closed by this pull request
Remove full reload of preview #12517
Closed
@ghost ghost self-requested a review April 3, 2024 09:04
ghost
ghost reviewed Apr 3, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a lot of great work! 👏
A few comments added 😄

frontend/packages/ux-editor/src/AppContext.test.tsx Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/AppContext.test.tsx Outdated Show resolved Hide resolved
...mponents/TextResource/TextResourceEditor/TextResourceValueEditor/TextResourceValueEditor.tsx Show resolved Hide resolved
frontend/packages/ux-editor/src/hooks/mutations/useDeleteLayoutMutation.test.ts Outdated Show resolved Hide resolved
frontend/packages/ux-editor/src/hooks/mutations/useDeleteLayoutMutation.test.ts Outdated Show resolved Hide resolved
@mlqn mlqn requested a review from a user April 5, 2024 09:55
ghost
ghost approved these changes Apr 5, 2024
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM😄

@mlqn mlqn merged commit cd168f2 into main Apr 5, 2024
11 checks passed
@mlqn mlqn deleted the 12517-remove-full-reload-of-preview branch April 5, 2024 10:12
Jondyr pushed a commit that referenced this pull request Jun 10, 2024
@mlqn @Jondyr
Remove full reload of Preview (v4) (#12534)
7a4e871 
* Invalidate queries of Preview instead of reloading it

* Revert v3 changes

* Refactor invalidate/refetch functions

* Move refetch to mutations

* Remove store & reducers

* Remove layout from storage

* New hook to handle selectedLayoutSetName

* Cleanup imports

* Refactoring

* Cleanup useSelectedFormLayoutSetName hook

* Remove warning

* Revert changes of useSelectedFormLayoutSetName

* Fix preview when updating layout name

* Remove redux

* Refactor preview path

* Fix tests

* Remove applicationMetadataSagas

* Fix unit tests

* Fix tests

* Fix tests

* Fix warnings

* Move useSelectedFromLayoutName in AppContext

* Cleanup

* Add tests for AppContext

* Add missing tests

* Add missing tests for AppContext

* Cleanup tests

* Fix Preview for v3

* Fix extra reloads

* Update landing page to open right layout

* Remove extra refetch

* Fix refetch/reload of preview when deleting a component

* Fix comments

* Remove removeSelectedFormLayoutSetName

* Fix unit tests

* Fix unit tests

* Changes after cr

* Add missing changes

* Add tests for TextResourceValueEditor
@mlqn mlqn mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
area/dashboard Area: Related to the dashboard application area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. kind/dependencies Used for issues or pull requests that are dependency updates solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
1 participant
@mlqn