Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all sagas #12453

Closed
framitdavid opened this issue Mar 6, 2024 · 2 comments
Closed

Remove all sagas #12453

framitdavid opened this issue Mar 6, 2024 · 2 comments
Labels
status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design.

Comments

@framitdavid
Copy link
Collaborator

We should review the remaining sagas in app-development and get rid of them... Here is an overview of the current sagas available:

function* root(): SagaIterator {
  yield fork(watchHandleFetchServiceSaga);
  yield fork(watchHandleFetchServiceNameSaga);
  yield fork(watchHandleSaveServiceNameSaga);
  yield fork(watchHandleFetchInitialCommitSaga);
  yield fork(watchHandleFetchServiceConfigSaga);
  yield fork(watchHandleSaveServiceConfigSaga);
  yield fork(applicationMetadataSagas);
  yield fork(appDeploymentSagas);
  yield fork(userSagas);
}

export const sagaMiddleware = createSagaMiddleware();

export const run = () => sagaMiddleware.run(root);
@framitdavid framitdavid converted this from a draft issue Mar 6, 2024
@framitdavid
Copy link
Collaborator Author

Today, we also have code that creates an application metadata file if it doesn't exist (getApplicationMetadataSaga). We should completely remove this type of code. We cannot guarantee the accuracy of the recreated file; it is retrieved from the app-template. For instance, if you have a v3 app and delete the application metadata, a new application metadata will be created, based on a v4 app.

@framitdavid framitdavid added the status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design. label Mar 6, 2024
@mlqn
Copy link
Contributor

mlqn commented Aug 28, 2024

Fixed by #13193
And the code that created a missing application metadata was also removed here #12534

@mlqn mlqn closed this as completed Aug 28, 2024
@github-project-automation github-project-automation bot moved this to ✅ Done in Team Studio Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready-for-specification Status: Used for issues that are ready for functional decription og detailed design.
Projects
Archived in project
Development

No branches or pull requests

2 participants