Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up and adding lots of docs about options (code lists / svaralternativer) #1934

Merged
merged 36 commits into from
Dec 19, 2024

Conversation

olemartinorg
Copy link
Contributor

@olemartinorg olemartinorg commented Dec 10, 2024

I saw that the guide for options-based comonents were severly lacking, so I pulled up my sleeves to add the missing things.

Also introduces docs for using an expression to filter options:

And adds docs for queryParameters with examples using expressions:

Ole Martin Handeland added 27 commits December 3, 2024 15:33
…out query parameters (they're not useful in any other contexts)
@olemartinorg olemartinorg marked this pull request as ready for review December 10, 2024 14:37
@olemartinorg olemartinorg self-assigned this Dec 11, 2024
@olemartinorg olemartinorg changed the title Cleaning up and adding lots of docs about options (svaralternativer) Cleaning up and adding lots of docs about options (code lists / svaralternativer) Dec 16, 2024
@olemartinorg olemartinorg merged commit d83b894 into master Dec 19, 2024
4 checks passed
@olemartinorg olemartinorg deleted the options-rewrite branch December 19, 2024 14:40
@olemartinorg
Copy link
Contributor Author

olemartinorg commented Dec 19, 2024

Docs are out:

Post-merge review is very welcome! 🙏 I merged this before reviews were finished as some docs are better than no docs. As this functionality was released in prod today, having docs for it is time-critical.

Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Veldig bra jobba, dette er et veldig løft 🚀

Kommentarene mine er en blanding av opprettinger og forslag, så håper du klarer å se forskjell på hva som er hva 😅 jeg kan også ha kommentert én ting på ett språk, men ikke den andre, selv om det kanskje gjelder for begge filene, så gjerne dobbeltsjekk om du tror det kan gjelde begge 🙏

Håper det ikke ble forvirrende, bare å spørre om det er noe uklart!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🧪 Test
Development

Successfully merging this pull request may close these issues.

2 participants