-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleaning up and adding lots of docs about options (code lists / svaralternativer) #1934
Conversation
… with the older PDF generator)
…out query parameters (they're not useful in any other contexts)
… configuration examples expandable.
…! it's what I made all these changes for!)
Docs are out:
Post-merge review is very welcome! 🙏 I merged this before reviews were finished as some docs are better than no docs. As this functionality was released in prod today, having docs for it is time-critical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Veldig bra jobba, dette er et veldig løft 🚀
Kommentarene mine er en blanding av opprettinger og forslag, så håper du klarer å se forskjell på hva som er hva 😅 jeg kan også ha kommentert én ting på ett språk, men ikke den andre, selv om det kanskje gjelder for begge filene, så gjerne dobbeltsjekk om du tror det kan gjelde begge 🙏
Håper det ikke ble forvirrende, bare å spørre om det er noe uklart!
I saw that the guide for options-based comonents were severly lacking, so I pulled up my sleeves to add the missing things.
Also introduces docs for using an expression to filter options:
And adds docs for
queryParameters
with examples using expressions:mapping
(aka query parameters) app-frontend-react#1181