-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filtering support for all options-components #2806
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng options twice), finding the preselected option after filtering, removing the warning that is no longer applicable when the preselected option is always found.
…gether with option filtering
olemartinorg
added
the
kind/product-feature
Pull requests containing new features
label
Dec 10, 2024
…, until I saw the comment I made long ago about that leading to a bad developer experience. Trying to stop myself from doing this again in the future.
…need to bootstrap the app twice.
…e tests that failed, as options were never again the exact same object as before.
…mode, and setting it again if using optionFilter
…ng test to make sure that is tested more thoroughly.
Quality Gate passedIssues Measures |
paal2707
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ser bra ut! :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds support for filtering options via an expression. The
optionFilter
property allows an expression that will run for each of the available options, and will only keep the option if the expression returnstrue
.An example from the
ttd/frontend-test
test-case:Related Issue(s)
Verification/QA
kind/*
label to this PR for proper release notes grouping