Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First edition of combinational computer series. #641
base: master
Are you sure you want to change the base?
First edition of combinational computer series. #641
Changes from 2 commits
96813da
9ab4848
710134e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm able to go to byjus.com just fine, but I get this when using that full URL. Is this error misleading, or does it actually have to do with me being European? If it's the latter, then consider changing the URL so it maybe points to a different website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to point out the green wire seen at the bottom of the arithmetic combinator. Or you can edit the picture so the green wire is highlighted. Idk how you'd highlight it nicely, but maybe by marking it with a very faint color or by having an arrow point to it. But I think just mentioning it in the caption is clear enough as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you could recreate the pic with the combinators spaced out a bit more, and you'd arrange them so the inputs are on the left and the output on the right, then it'd make it much easier to follow for me. I also recommend giving the red arrows a different color, since they blend with the red wiring. A color like say blue or magenta should look decent and distinct from the scene. If you update the picture you might also need to edit later text to reflect the new layout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this is because it'd otherwise subtract twice and cause the signal to end up too low, but I'm not sure if that's the reason since you're referring to a "multi-combinator" process. You may want to extend that sentence with a comma to briefly explain why it must be only one tick long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I presume this is because it'd otherwise subtract twice and cause the signal to end up too low, but I'm not sure if that's the reason since you're referring to a "multi-combinator" process. You may want to extend that sentence with a comma to briefly explain why it must be only one tick long.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put an actual tiny Waldo in there :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did! ...ish. It's meant to get you to try and spot where the engineer is. He's in there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word "interfacer" confuses me. Is it referring to an actual Interface here, or just something synonymous with user/system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to remind the reader of why address 4 accessing the second raw memory cell makes sense (the reason being that 32 bits are being split into four groups of 8 bits). You can say that an address of '0' accesses the first memory cell's first byte, '1' its second byte, '2' its third, '3' its fourth, and '4' referring to the second memory cell's first byte.
This file was deleted.