Harmonize remote and local options & bump to 0.5.0 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxleDrut
force-pushed
the
harmonize-remote-local
branch
from
ca7c256 to
14ec6e2
Compare
MaxleDrut
commented
Nov 29, 2023
added 3 commits
November 29, 2023 16:01
When we introduced the local provider, we made it so we declare its options (nb_photons, kappa_1...) when using get_backend(). This is contradictory to what is happening in the remote provider, where options must be passed in execute(). This commit harmonizes this behaviour by allowing to set the options in get_backend() for the remote provider. (which actually makes some sense to do it like this when we want to set the nb_photons for example). This allows to quickly swap between the local and remote provider. We aim to stay as permissive as possible, by still letting the user passing options at execute() for the remote provider.
This is a fix where we found out the "kappa1" parameter of targets was not converted to "kappa_1" in snake_case when getting a backend as it should. This came from our home made to_snake_case and to_camel_case functions using some obscure regex. Instead, this commit replaces these functions with Pydantic's, that are more tested and proven.
MaxleDrut
force-pushed
the
harmonize-remote-local
branch
from
14ec6e2 to
6682188
Compare
jrj-d
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: (copied from commit)
When we introduced the local provider, we made it so we declare its options (nb_photons, kappa_1...) when using get_backend().
This is contradictory to what is happening in the remote provider, where options must be passed in execute().
This commit harmonizes this behaviour by allowing to set the options in get_backend() for the remote provider. (which actually makes some sense to do it like this when we want to set the nb_photons for example).
This allows to quickly swap between the local and remote provider.
We aim to stay as permissive as possible, by still letting the user passing options at execute() for the remote provider.
Safe to revert.