-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.4.1 & fix state preparation in remote backend #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new version introduces breaking changes and will require some work to be supported.
Simulation used to fail when the number of qubits of the processor was larger than the number of qubits supported by AerSimulator. This commit fixes this. Note that this is caused by the release qiskit-aer==0.13.0, and we forbid this version in the next commit because it is too slow. Nevertheless, the fix is valuable in itself, for the day 0.13.1 comes out or if we find a fix for the slowness.
This release made aer irritatingly slow.
The name of instructions should not be an arbitrary string reflecting the true nature of the instruction, but rather an existing Qiskit intstruction. We knew that already in local/, but since the next commits will make remote/ perform actual transpilation before sending the circuit to the API, this problem became apparent.
This commit, by using a new version of qiskit-qir-alice-bob-fork, removes a significant piece of technical debt: * The version of qiskit-qir now supports native operations like mx, prepare_x, prepare_z * This makes it possible for the remote backend to transpile to native A&B qir and send it directly to the API. Additionally, this commit factorizes the LocalStatePreparationPlugin and the RemoteStatePreparationPlugin into a single StatePreparationPlugin. As a consequence, this means that remote backends now cause Qiskit to perform some transpilation when a circuit is executed. This will allow us to support through the API a target like EMU:6Q:PHYSICAL_CATS.
The plugin now gets the list of instructions from the target provided to the plugin, rather than from the processor itself. This will enable to use this plugin for remote/ as well.
This will allow us to use this plugin in remote/ when executing against logical backends like EMU:6Q:LOGICAL_QUBITS through the API.
The remote/ backend now uses the SKSynthesisPlugin when (1) rotations are absent from the gate set and (2) H and T are in the gate set. This will allow us to support logical qubit targets through the API. The drawback is that the decision rule (1 + 2 above) may not be suitable for some given situation in the future. Time will tell!
MaxleDrut
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me, great improvement!
jrj-d
force-pushed
the
fix_state_preparation
branch
from
November 6, 2023 17:27
d9e71e1
to
46e7352
Compare
MaxleDrut
approved these changes
Nov 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.