Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sort_ascend utility function to sort decimals #25

Merged
merged 5 commits into from
Dec 27, 2024
Merged

Fix sort_ascend utility function to sort decimals #25

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
45ac0b2
refactor[DataTomeAnalysis]!: Optimize Median method from TC O(N log N…
mohammedelgammal Dec 11, 2024
2fc4734
fix[DataTomeAnalysis]: renaming min to dt_min to use utility minimum …
mohammedelgammal Dec 16, 2024
d074fbe
fix:[DataTomeUtils]: Refactoring dt_min utility function
mohammedelgammal Dec 16, 2024
0d7971e
fix[DataTomeUtils]: Refactor sort_ascend Utility Function to precisel…
mohammedelgammal Dec 27, 2024
6456b75
Merge branch 'main' into fix_sort_ascend_util
mohammedelgammal Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/DataTomeUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,11 @@ int sort_ascend(const void *cmp1, const void *cmp2) {
TypeOfArray b = *((TypeOfArray *)cmp2);
TypeOfArray a = *((TypeOfArray *)cmp1);

return (int)a - b;
if (a > b)
return 1;
else if (a < b)
return -1;
return 0;
}

template <typename TypeOfArray>
Expand All @@ -21,8 +25,8 @@ void swap(TypeOfArray &a, TypeOfArray &b) {
b = temp;
}

template <typename T>
const T &dt_min(const T &a, const T &b) {
template <typename TypeOfArray>
const TypeOfArray &dt_min(const TypeOfArray &a, const TypeOfArray &b) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change to comply with the standard used on the codebase! I was thinking of writing it myself. Thank you for noticing it.

return (a < b) ? a : b;
}

Expand Down
Loading