Fix sort_ascend utility function to sort decimals #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…) to O(N) using IntroSort Algorithm Median now uses introSelect algorithm merging between quickSelect and medianOfMedians Algorithm feat[DataTomeUtils]: Adding dt_min helper function to get minimum value between two values and swap to swap two values resolves (AlexandreHiroyuki#18)
…function instead of cpp std lib
…y sort decimal numbers resolves AlexandreHiroyuki#24
AlexandreHiroyuki
approved these changes
Dec 27, 2024
| template <typename T> | ||
| const T &dt_min(const T &a, const T &b) { | ||
| template <typename TypeOfArray> | ||
| const TypeOfArray &dt_min(const TypeOfArray &a, const TypeOfArray &b) { |
There was a problem hiding this comment.
Nice change to comply with the standard used on the codebase! I was thinking of writing it myself. Thank you for noticing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor sort_ascend function to avoid losing precision when sorting decimals. resolves #24