Fix no-payload commit in consumer #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyaskuti
commented
Mar 5, 2024
| @@ -86,7 +86,10 @@ def commit( # type: ignore[override] | |||
| if message is not None: | |||
| return super().commit(message=message, asynchronous=False) | |||
|
|
|||
| return super().commit(offsets=offsets, asynchronous=False) | |||
| if offsets is not None: | |||
| return super().commit(offsets=offsets, asynchronous=False) | |||
There was a problem hiding this comment.
Note: because this is a C library, there is a difference between providing None and not providing a parameter.
There was a problem hiding this comment.
oh this is not None being different from != None and different from bool(optional) stole me so much time in my life 😭
matyaskuti
force-pushed
the
matyaskuti/fix_rest_proxy_commit_empty_payload
branch
2 times, most recently
from
6ffb30a to
4c21063
Compare
The confluent-kafka `Consumer.commit` method can be called with no parameters, then the current partition assignment's offsets are used (see the documentation at https://docs.confluent.io/platform/current/clients/confluent-kafka-python/html/index.html#confluent_kafka.Consumer.commit). The previous behaviour was erroneous, raising a `TypeError`, thus an HTTP 500 when in the REST proxy's consumer manager a commit is performed with an empty payload.
matyaskuti
force-pushed
the
matyaskuti/fix_rest_proxy_commit_empty_payload
branch
from
4c21063 to
c8f3923
Compare
eliax1996
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Prompted by a Sentry error, the issue is "triggered" by this line in the consumer manager.
The confluent-kafka
Consumer.commitmethod can be called with no parameters, then the current partition assignment's offsets are used (see the documentation athttps://docs.confluent.io/platform/current/clients/confluent-kafka-python/html/index.html#confluent_kafka.Consumer.commit).
The previous behaviour was erroneous, raising a
TypeError, thus an HTTP 500 when in the REST proxy's consumer manager a commit is performed with an empty payload.