Add tests for empty payload consumer commit #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyaskuti
force-pushed
the
matyaskuti/consumer_empty_commit_test
branch
from
9211c5e to
2486768
Compare
matyaskuti
changed the title
matyaskuti
force-pushed
the
matyaskuti/consumer_empty_commit_test
branch
from
2486768 to
d00ab8a
Compare
eliax1996
suggested changes
Mar 8, 2024
| topic_name = new_topic(admin_client) | ||
| offsets_path = f"/consumers/{group_name}/instances/{instance_id}/offsets{trail}" | ||
| assign_path = f"/consumers/{group_name}/instances/{instance_id}/assignments{trail}" | ||
| consume_path = f"/consumers/{group_name}/instances/{instance_id}/records{trail}?timeout=5000" |
There was a problem hiding this comment.
Why the optional trailing?
| @@ -251,6 +251,80 @@ async def test_offsets(rest_async_client, admin_client, trail): | |||
| assert "partition" in data and data["partition"] == 0, f"Unexpected partition {data}" | |||
|
|
|||
|
|
|||
| @pytest.mark.parametrize("trail", ["", "/"]) | |||
There was a problem hiding this comment.
I cannot see the value of that parameter
There was a problem hiding this comment.
I've followed the pattern of the other tests here, which all have it. I sort of understand why that is there, with some frameworks this can go wrong fairly easy :(
There was a problem hiding this comment.
I guess what's odd is that we support both, but since we do, I guess it makes sense to test it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Following up on #833, adding tests around the fix that was hastily implemented there.