Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protobuf-compiler version to match Debian bullseye #736

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fix protobuf-compiler version to match Debian bullseye #736

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion container/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ RUN groupadd --system karapace \
&& chown --recursive karapace:karapace /opt/karapace /var/log/karapace

# Install protobuf compiler.
ARG PROTOBUF_COMPILER_VERSION="3.12.4-1"
ARG PROTOBUF_COMPILER_VERSION="3.12.4-1+deb11u1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the version should be removed here as the compiler is from the Debian packages. There is only one version available.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was the one adding this, without much thought to it other than to adhere to the linter:

karapace/.pre-commit-config.yaml

Line 63 in 9a4f91e

- repo: https://github.com/hadolint/hadolint

We would just need to add another ignore there if we remove the version pin.

I'll refrain from commenting on whether it's a good idea to pin apt packages or not, but I'll link the rationale from the tool itself: https://github.com/hadolint/hadolint/wiki/DL3008#rationale. I'm fine with ditching this practice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had rebased other PR on this just to get CI builds passing. I'm open to non-pinned versions here, but as the build is passing, I'm not planning to actively work on it now.

RUN apt-get update \
&& apt-get install --assume-yes --no-install-recommends \
protobuf-compiler=$PROTOBUF_COMPILER_VERSION \
Expand Down