Fix protobuf-compiler version to match Debian bullseye #736
Conversation
| @@ -32,7 +32,7 @@ RUN groupadd --system karapace \ | |||
| && chown --recursive karapace:karapace /opt/karapace /var/log/karapace | |||
|
|
|||
| # Install protobuf compiler. | |||
| ARG PROTOBUF_COMPILER_VERSION="3.12.4-1" | |||
| ARG PROTOBUF_COMPILER_VERSION="3.12.4-1+deb11u1" | |||
There was a problem hiding this comment.
Maybe the version should be removed here as the compiler is from the Debian packages. There is only one version available.
There was a problem hiding this comment.
I was the one adding this, without much thought to it other than to adhere to the linter:
karapace/.pre-commit-config.yaml
Line 63 in 9a4f91e
We would just need to add another ignore there if we remove the version pin.
I'll refrain from commenting on whether it's a good idea to pin apt packages or not, but I'll link the rationale from the tool itself: https://github.com/hadolint/hadolint/wiki/DL3008#rationale. I'm fine with ditching this practice.
There was a problem hiding this comment.
I had rebased other PR on this just to get CI builds passing. I'm open to non-pinned versions here, but as the build is passing, I'm not planning to actively work on it now.
About this change - What it does
Fix protobuf-compiler version to match Debian bullseye