Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DG with Storage, Add Command, use case and PPP #252

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

ji-just-ji
Copy link

No description provided.

@ji-just-ji ji-just-ji added this to the v1.4 milestone Nov 13, 2023
@ji-just-ji
Copy link
Author

This is what I have so far, I'll try to wake for the meeting.

@ji-just-ji ji-just-ji marked this pull request as ready for review November 13, 2023 21:02
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3a3c921) 81.67% compared to head (a7b754c) 81.67%.
Report is 10 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #252   +/-   ##
=========================================
  Coverage     81.67%   81.67%           
  Complexity      593      593           
=========================================
  Files            78       78           
  Lines          1746     1746           
  Branches        174      174           
=========================================
  Hits           1426     1426           
  Misses          294      294           
  Partials         26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@marquestye marquestye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@marquestye marquestye merged commit 84ffff6 into AY2324S1-CS2103T-T13-0:master Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants