Skip to content

Commit

Permalink
Merge pull request #252 from ji-just-ji/master
Browse files Browse the repository at this point in the history
Update DG with Storage, Add Command, use case and PPP
  • Loading branch information
marquestye authored Nov 14, 2023
2 parents dac6a79 + a7b754c commit 84ffff6
Show file tree
Hide file tree
Showing 6 changed files with 435 additions and 6 deletions.
77 changes: 77 additions & 0 deletions docs/DeveloperGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,62 @@ Alternative 1 is ultimately chosen as it helps abstracts out the logic for diffe
- what happens when the user modifies the moduleplan
- userprefs considered the same feature? if too long can split into another one

**Overview:**

Modcraft stores two types of information on the hard drive, ModulePlan and UserPrefs(User Preferences).
ModulePlan stores the user's last saved module plan when using Modcraft allowing the user to access their module plan
across sessions. UserPrefs contains the last known user interface settings when using Modcraft allowing the user to
return to their preferred interface across sessions.

ModulePlan is stored as `moduleplan.json` and UserPrefs is stored as `preferences.json`. Both files will be created if
they do not already exist in the same folder in which the Modcraft jar file is stored. While users are free to access
and modify the files as they wish it is recommended that they make a backup before any modifications. If Modcraft
cannot access a file, it will be deleted and replaced with a new empty file.

**Feature details:**

1. When the user launches the application, if there is no `moduleplan.json` or `preferences.json` file detected in the
same folder as Modcraft or they are corrupted, Modcraft will create them and populate them with the default moduleplan
and preferences respectively.
2. If there are existing `moduleplan.json` and `preferences.json` files with appropriate data, Modcraft will read the
module plan from `moduleplan.json` and user preferences from `preferences.json`, loading the application with the
information obtained from the files.
3. Upon execution of any command that alters the user's module plan, the changes will automatically be saved into
`moduleplan.json`.
4. Upon alteration of any part of the user interface, the changes will automatically be saved into `preferences.json`.


**Initialization sequence:**

1. At startup, `MainApp` calls `MainApp#initPrefs` to attempt to parse the `preferences.json` file.
2. `MainApp#initPrefs` calls `Storage#readUserPrefs` to obtain the user preferences as a `UserPrefs` object.
2a. If `DataLoadingException` is thrown, a new `preferences.json` file will be created with default preferences.
3. `JsonUserPrefsStorage` deserializes the JSON file by calling `JsonUtil#readJsonFile` into a `UserPrefs` object.
3. `MainApp` creates a `StorageManager` object with the file paths of `preferences.json` and `moduleplan.json`.
4. `MainApp#initModelManager` is then called which calls `Storage#readModulePlan` attempting to parse the
`moduleplan.json` file and create a `modulePlan` object.
4a. If `DataLoadingException` is thrown, a new `moduleplan.json` file will be created with the default module plan.
5. `JsonModulePlanStorage` deserializes the JSON file into a `JsonSerializableModulePlan` object by calling
`JsonUtil#readJsonFile`.
5a. The `JsonSerializableModulePlan` object represents a list of `JsonAdaptedModule` objects, created during
deserialization.
6. `JsonModulePlanStorage` then calls `JsonSerizaliableModulePlan#toModelType` to create the `ReadOnlyModulePlan` object.
6a. `JsonAdaptedModule` then calls `JsonAdapedModule#toModelType` for the creation of each `module`.
7. `ModulePlan` is returned to `MainApp` where it is used to initialize `ModelManager`, which is used during command
execution.
8. A `DataLoadingException` is thrown when any of the following occus.
- the file cannot be found.
- an error occurs during deserialization, or
- the data contains invalid values.


This can be seen in the sequence diagram below

<puml src="diagrams/StorageInitSequenceDiagram.puml" />




### Info Module Command

**Overview:**
Expand Down Expand Up @@ -369,6 +425,24 @@ The activity diagram for adding a `Module` into the module plan

<puml src="diagrams/AddModuleActivityDiagram.puml" width="450" />

The sequence of the `add` command is as follows:

1. The user inputs the `add` command.<br>
e.g. `add CS2040S y/1 s/1 g/A`
2. The `LogicManager` calls the `ModulePlanParser#parseCommand` to parse the command.
3. The `ModulePlanParser` then creates a new `AddCommandParser` to parse the fields provided by the user and
a new `AddCommand` is created.
4. The `AddCommand` checks if the `ModuleCode` is valid bt calling `Model#getModuleFromDb` and retrieves
the module if it exists from the database.
5. `AddCommand` then fills the user inputs into the module using the `Module#fillUserInputs` function.
6. `AddCommand` then attempts to add the module into the Model via `Model#addModule`.
7. If `ModuleCode`, the user inputs are valid, and the Model does not contain the module, `AddCommand` will
successfully add the new `Module` into the module plan.

The following sequence diagram shows how the `add` command works:

<puml src="diagrams/AddOverallSequenceDiagram.puml" width="450" />


### Edit Module Command

Expand Down Expand Up @@ -414,6 +488,9 @@ The following activity diagram shows the logic of deleting a `Module` from the m

<puml src="diagrams/DeleteCommandActivityDiagram.puml" width="450" />




<br>

The sequence of the `delete` command is as follows:<br>
Expand Down
53 changes: 53 additions & 0 deletions docs/diagrams/AddExecuteSequenceDiagram.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
@startuml
!include style.puml
skinparam ArrowFontStyle plain

box Logic LOGIC_COLOR_T1
participant "a:AddCommand" as AddCommand LOGIC_COLOR
participant "<<class>>\nAddCommand" as AddCommandClass LOGIC_COLOR
participant "m:Module" as Module LOGIC_COLOR
participant "result:CommandResult" as CommandResult LOGIC_COLOR
end box

box Model MODEL_COLOR_T1
participant ":Model" as Model MODEL_COLOR
end box

[-> AddCommand : execute()
activate AddCommand

AddCommand -> Model : getModule("CS2040S")
activate Model

Model --> AddCommand : moduleToAdd
deactivate Model

AddCommand -> AddCommand : fillUserInputs(year, semester, grade)
activate AddCommand

create Module
AddCommand -> Module
activate Module
Module --> AddCommand: m
deactivate Module

AddCommand --> AddCommand: moduleToAdd
deactivate AddCommand

AddCommand -> Model : addModule(moduleToAdd)
activate Model

Model --> AddCommand : newModule
deactivate Model

create CommandResult
AddCommand -> CommandResult
activate CommandResult

CommandResult --> AddCommand : result
deactivate CommandResult

[<-- AddCommand : result
deactivate AddCommand

@enduml
89 changes: 89 additions & 0 deletions docs/diagrams/AddOverallSequenceDiagram.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,89 @@
@startuml
!include style.puml
skinparam ArrowFontStyle plain

box Logic LOGIC_COLOR_T1
participant ":LogicManager" as LogicManager LOGIC_COLOR
participant ":ModulePlanParser" as ModulePlanParser LOGIC_COLOR
participant ":AddCommandParser" as AddCommandParser LOGIC_COLOR
participant "a:AddCommand" as AddCommand LOGIC_COLOR
participant "result:CommandResult" as CommandResult LOGIC_COLOR
end box

box Model MODEL_COLOR_T1
participant "m:Module" as Module MODEL_COLOR
participant "model:Model" as Model MODEL_COLOR
end box
[-> LogicManager : execute("Add CS2040S")
activate LogicManager

LogicManager -> ModulePlanParser : parseCommand("Add CS2040S y/1 s/1 g/A")
activate ModulePlanParser

create AddCommandParser
ModulePlanParser -> AddCommandParser
activate AddCommandParser

AddCommandParser --> ModulePlanParser
deactivate AddCommandParser

ModulePlanParser -> AddCommandParser : parse(arg)
activate AddCommandParser

create AddCommand
AddCommandParser -> AddCommand : new AddCommand("CS2040S", "1", "1", "A")
activate AddCommand

AddCommand --> AddCommandParser
deactivate AddCommand

AddCommandParser --> ModulePlanParser : a
deactivate AddCommandParser
'Hidden arrow to position the destroy marker below the end of the activation bar.
AddCommandParser -[hidden]-> ModulePlanParser
destroy AddCommandParser

ModulePlanParser --> LogicManager : a
deactivate ModulePlanParser

LogicManager -> AddCommand : execute(model)
activate AddCommand

AddCommand -> Model : getModuleFromDb(moduelCode)
activate Model
Model --> AddCommand : newModule
deactivate Model

AddCommand -> AddCommand : fillUserInputs(year, semester, grade)
activate AddCommand

create Module
AddCommand -> Module
activate Module
Module --> AddCommand: moduleToAdd
deactivate Module


AddCommand --> AddCommand: moduleToAdd
deactivate AddCommand

AddCommand -> Model : addModule(moduleToAdd)
activate Model
Model --> AddCommand
deactivate Model

create CommandResult
AddCommand -> CommandResult : moduleToAdd
activate CommandResult

CommandResult --> AddCommand : result
deactivate CommandResult

AddCommand --> LogicManager : result
deactivate AddCommand
AddCommand -[hidden]-> LogicManager : result
destroy AddCommand

[<--LogicManager : result
deactivate LogicManager
@enduml
43 changes: 43 additions & 0 deletions docs/diagrams/AddParseSequenceDiagram.puml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
@startuml
!include style.puml
skinparam ArrowFontStyle plain

box Logic LOGIC_COLOR_T1
participant ":AddCommandParser" as AddCommandParser LOGIC_COLOR
participant ":ParserUtil" as ParserUtil LOGIC_COLOR
participant "a:AddCommand" as AddCommand LOGIC_COLOR
end box

[-> AddCommandParser : parse("add CS2040S y/1 s/1 g/A")
activate AddCommandParser

create ParserUtil
AddCommandParser -> ParserUtil : parseModuleCode("CS2040S")
activate ParserUtil
ParserUtil --> AddCommandParser : moduleCode:ModuleCode

AddCommandParser -> ParserUtil : parseModuleCode("1")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode

AddCommandParser -> ParserUtil : parseModuleCode("1")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode

AddCommandParser -> ParserUtil : parseModuleCode("A")
ParserUtil --> AddCommandParser : moduleCode:ModuleCode

deactivate ParserUtil

create AddCommand
AddCommandParser -> AddCommand : new AddCommand("CS2040S", amd)
activate AddCommand

AddCommand --> AddCommandParser : a
deactivate AddCommand

[<-- AddCommandParser : a
deactivate AddCommandParser
'Hidden arrow to position the destroy marker below the end of the activation bar.
[<-[hidden]- AddCommandParser
destroy AddCommandParser

@enduml
Loading

0 comments on commit 84ffff6

Please sign in to comment.