Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded charge balance in primordial chemistry #1646

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

psharda
Copy link
Collaborator

@psharda psharda commented Aug 29, 2024

We now use a function that does the charge balance for primordial chemistry, similar to that done for metal chemistry in #1642

Copy link
Collaborator

@BenWibking BenWibking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@zingale zingale merged commit fb8b008 into AMReX-Astro:development Aug 29, 2024
29 checks passed
@psharda psharda deleted the balance_charge_popiii branch September 17, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants