Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do charge conservation normalization in a network-independent way #397

Closed
BenWibking opened this issue Sep 24, 2023 · 5 comments
Closed
Assignees

Comments

@BenWibking
Copy link
Collaborator

Since the electron abundance normalization depends on the charge of all of the species, it should be moved into the network-specific files in Microphysics, or somehow re-written so it does not assume the species and their charges, as it does currently:

chemstate.xn[0] = -chemstate.xn[3] - chemstate.xn[7] + chemstate.xn[1] + chemstate.xn[12] + chemstate.xn[6] + chemstate.xn[4] +

@psharda
Copy link
Contributor

psharda commented Sep 24, 2023

I think this is better done in Quokka rather than Microphysics.

@BenWibking
Copy link
Collaborator Author

I think this is better done in Quokka rather than Microphysics.

Ok. Is there a way to have it compute what the normalization should be in a way that works for any network?

@BenWibking BenWibking changed the title move charge conservation normalization into Microphysics do charge conservation normalization in a network-independent way Sep 24, 2023
@psharda
Copy link
Contributor

psharda commented Sep 25, 2023

yeah, we can store the charge of each particle in an array that the user can fill in the input file?

@BenWibking
Copy link
Collaborator Author

@psharda you do this now, right? If so, I'll close this issue.

@psharda
Copy link
Contributor

psharda commented Sep 24, 2024

yes, its done in microphysics via AMReX-Astro/Microphysics#1646

@psharda psharda closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants