-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Deref MainTrace
type to ColMatrix
#1214
refactor: Deref MainTrace
type to ColMatrix
#1214
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! Let a few minor nits.
Let's fix the CI too. You can fix by running locally:
// fix any clippy errors
$ cargo +nightly clippy --all -- -D clippy::all -D warning
// format once all fixes are done
$ cargo fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@bobbinth want to take a look before we merge?
@iammadab oops can you fix the CI? Basically an explicit import of |
@plafer pushed no-std fix, we can run CI again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you for working on this! I left one comment inline - but it could be as simple as adding a comment to the relevant method.
The clippy error is due to the latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good! Thank you again!
5f36479
into
0xPolygonMiden:al-simplify-aux
Describe your changes
relevant issue: #1201