Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExecutionTrace.main_trace: change type to MainTrace #1201

Closed
plafer opened this issue Jan 17, 2024 · 2 comments
Closed

ExecutionTrace.main_trace: change type to MainTrace #1201

plafer opened this issue Jan 17, 2024 · 2 comments

Comments

@plafer
Copy link
Contributor

plafer commented Jan 17, 2024 •
edited
Loading

We should have main_trace be a MainTrace (and implement AsRef<ColMatrix<Felt>> for MainTrace). This is really the type that we want in the VM, and we can convert it in a ColMatrix for winterfell's Trace::main_segment()

Originally posted by @plafer in #1140 (comment)
@plafer plafer mentioned this issue Jan 17, 2024
Merged
This was referenced Jan 22, 2024
Closed
Merged
@bobbinth
Copy link
Contributor

@plafer - this is now closed by #1214, right?

@plafer
Copy link
Contributor Author

plafer commented Feb 27, 2024

Yup!

@plafer plafer closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@plafer @bobbinth