Stack inputs serde #1168
Merged
Stack inputs serde #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackaugusto
force-pushed
the
hacka-kernel-serde
branch
from
24352ba to
cbfdb4a
Compare
hackaugusto
force-pushed
the
hacka-stack-inputs-serde
branch
from
8a300e6 to
2a68026
Compare
bobbinth
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Looks good! Thank you! I left one comment inline regarding reducing the max number of inputs to u16::MAX (probably still way too generous). Once this is addressed, we can merge.
Also, let'd double check that this change doesn't break anything in the executable.
Lastly, this may break things in miden-base and miden-node - so, let's make sure we fix builds there shortly after we merge this.
core/src/stack/inputs.rs
Outdated
| @@ -6,6 +6,8 @@ use core::slice; | |||
| // STACK INPUTS | |||
| // ================================================================================================ | |||
|
|
|||
| const MAX_STACK_INPUTS_SIZE: usize = u32::MAX as usize; | |||
There was a problem hiding this comment.
We can probably limit this to u16:MAX.
hackaugusto
force-pushed
the
hacka-stack-inputs-serde
branch
from
2a68026 to
9617918
Compare
I ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds deserialization to the stack inputs
Checklist before requesting a review
nextaccording to naming convention.