Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stackoutputs: add deserializer and size validation #1169

Merged
merged 1 commit into from
Dec 2, 2023
Merged

stackoutputs: add deserializer and size validation #1169

merged 1 commit into from
Dec 2, 2023

Conversation

hackaugusto
Copy link
Contributor

Describe your changes

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@hackaugusto hackaugusto requested a review from bobbinth December 1, 2023 14:27
@hackaugusto hackaugusto force-pushed the hacka-stack-outputs-serde branch from 168298b to db487db Compare December 1, 2023 15:35
bobbinth
bobbinth approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I have the same comments here as in #1168.

core/src/stack/outputs.rs Outdated
@@ -33,6 +33,8 @@ pub struct StackOutputs {
overflow_addrs: Vec<u64>,
}

pub const MAX_STACK_OUTPUTS_SIZE: usize = u32::MAX as usize;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's limit this to u16:MAX.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed

@hackaugusto hackaugusto force-pushed the hacka-stack-outputs-serde branch from db487db to 27c65ee Compare December 2, 2023 13:12
@hackaugusto
Copy link
Contributor Author

tested binary with cargo run --release --features=executable,concurrent prove --assembly miden/examples/fib/fib.masm, its working

@hackaugusto hackaugusto merged commit 3d3f01d into next Dec 2, 2023
15 checks passed
@hackaugusto hackaugusto deleted the hacka-stack-outputs-serde branch December 2, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hackaugusto @bobbinth