-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 0.25 deprecations (and 0.26 errors). Fix the iOS warning. Fix logic bugs due properties being set in nondeterminstic orders. #8
base: master
Are you sure you want to change the base?
Conversation
…n warning due to the missing native module. This separates it out into a separate per-platform files to avoid the warning.
…rty in any order. But most properties only make sense to set *after* setting childText. This ensures that the views get updated and reflected, no matter what order they are set in.
Added another change to this, and updating the title to reflect it. Bugs were:
This third changelist fixes all of those issues. |
Ping? |
@mikelambert When running your fork, I've got
|
What version of RN are you using? RN changed their API for Event constructors as of 0.32 (due to the breaking change for android listed in https://github.com/facebook/react-native/releases/tag/v0.32.0), and this pull request now (with 1a8c1ef) fixes that for react-native-segmented-android as well. So this change is only compatible with 0.32 and up. |
Hi @mikelambert You right. I'll update my project and let you know |
No description provided.