Add copyright banner to UMD variant #429
Closed
+113
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has this been solved in a different way? |
|
That was a mistake, sorry. I'll look into the changes you made |
werthdavid
reviewed
Apr 26, 2022
| }, | ||
| data() { | ||
| return { | ||
| foo: 'foo', |
| @@ -504,7 +504,7 @@ arr-union@^3.1.0: | |||
| resolved "https://registry.yarnpkg.com/arr-union/-/arr-union-3.1.0.tgz#e39b09aea9def866a8f206e288af63919bae39c4" | |||
There was a problem hiding this comment.
I guess a fresh install to update that file would be useful
|
Thanks! It's not a big thing. Just thought, the copyright comments in the UMD version should match the reality... |
|
Have you seen my comments in the code? |
|
Yes, sorry for not replying immediately - daily work, you know. I hope to be able to look into this again today or tomorrow. Kind Regards and thanks again, |
|
any updates? |
|
Stale pull request message |
|
Sorry that I didn't manage to update the PR. Fair enough to close it after such a long time. |
|
if you manage to update it we can reopen it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding this library to our project (not on github, so I can't share a link, sorry), we noticed that the minified UMD variant (
dist/index.min.js) only contains a copyright comment for the externalts-custom-errormodule, but none for your own modules. This looked a bit misleading to us.This PR is a proposal how to address this. It uses a rollup plugin to add your LICENSE file as a banner comment to the build result. The banner is added in a way that terser doesn't remove it (
/*! ... */comment).