Fix bug where tribute didn't factor in the window scrolloffset.

zurb · Apr 14, 2016 · 4d47d4b · 4d47d4b
1 parent 296d930
commit 4d47d4b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/dist/tribute.js b/dist/tribute.js
@@ -858,9 +858,12 @@ if (!Array.prototype.find) {
           div.appendChild(span);
 
           var rect = element.getBoundingClientRect();
+          var doc = document.documentElement;
+          var windowLeft = (window.pageXOffset || doc.scrollLeft) - (doc.clientLeft || 0);
+          var windowTop = (window.pageYOffset || doc.scrollTop) - (doc.clientTop || 0);
           var coordinates = {
-            top: rect.top + span.offsetTop + parseInt(computed.borderTopWidth) + parseInt(computed.fontSize),
-            left: rect.left + span.offsetLeft + parseInt(computed.borderLeftWidth)
+            top: rect.top + windowTop + span.offsetTop + parseInt(computed.borderTopWidth) + parseInt(computed.fontSize),
+            left: rect.left + windowLeft + span.offsetLeft + parseInt(computed.borderLeftWidth)
           };
 
           this.getDocument().body.removeChild(div);

diff --git a/js/tribute.js b/js/tribute.js
@@ -781,9 +781,12 @@ if (!Array.prototype.find) {
       div.appendChild(span)
 
       let rect = element.getBoundingClientRect()
+      var doc = document.documentElement;
+      var windowLeft = (window.pageXOffset || doc.scrollLeft) - (doc.clientLeft || 0);
+      var windowTop = (window.pageYOffset || doc.scrollTop)  - (doc.clientTop || 0);
       let coordinates = {
-        top: rect.top + span.offsetTop + parseInt(computed.borderTopWidth) + parseInt(computed.fontSize),
-        left: rect.left + span.offsetLeft + parseInt(computed.borderLeftWidth)
+        top: rect.top + windowTop + span.offsetTop + parseInt(computed.borderTopWidth) + parseInt(computed.fontSize),
+        left: rect.left + windowLeft + span.offsetLeft + parseInt(computed.borderLeftWidth)
       }
 
       this.getDocument().body.removeChild(div)