Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor fixes #105

Merged
merged 2 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ name: .NET build and deploy to Azure WebApp
on:
workflow_call:
inputs:
DEPLOY_ON:
required: true
type: string
RUN_ON:
required: false
type: string
Expand Down Expand Up @@ -90,7 +87,7 @@ jobs:

deploy:
runs-on:
labels: ${{ inputs.DEPLOY_ON }}
labels: ${{ inputs.RUN_ON }}
group: ${{ inputs.RUNNERS_CONTAINER_GROUP }}
env: ${{ fromJson(inputs.ENV_VARIABLES) }}
environment: ${{ inputs.RELEASE_ENVIRONMENT }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/node-step-test-cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
required: false
type: string
default: "chrome"
TIMEOUT:
TESTS_TIMEOUT:
required: false
type: number
default: 30
Expand All @@ -42,7 +42,7 @@ env: "${{secrets}}"
jobs:
cypress-run:
if: ${{ inputs.RUN }}
timeout-minutes: ${{ inputs.TIMEOUT }}
timeout-minutes: ${{ inputs.TESTS_TIMEOUT }}
runs-on:
labels: ${{ inputs.RUN_ON }}
group: ${{ inputs.RUNNERS_CONTAINER_GROUP }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/node-workflow-common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ on:
required: false
type: string
default: "lcov.info"
TIMEOUT:
TESTS_TIMEOUT:
required: false
type: number
default: 30
Expand Down Expand Up @@ -66,7 +66,7 @@ jobs:
WORKING_DIRECTORY: ${{inputs.WORKING_DIRECTORY}}
CYPRESS_IMAGE: ${{inputs.CYPRESS_IMAGE}}
COVERAGE_ARTIFACT_NAME: ${{ inputs.COVERAGE_ARTIFACT_NAME }}
TIMEOUT: ${{ inputs.TIMEOUT }}
TESTS_TIMEOUT: ${{ inputs.TESTS_TIMEOUT }}
RUN: ${{ inputs.RUN }}
PROJECT: ${{ inputs.PROJECT }}
secrets: inherit
Expand Down
12 changes: 4 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ In addition, it is possible to specify these optional inputs:
- **COVERAGE_ARTIFACT_NAME**: The artifact's name for the _lcov.info_ file. By default, it is **lcov.info**.
- **ENABLE_TESTS**: Whether it should skip or not the cypress tests workflow. By default, it is **true**.
- **TIMEOUT**: Used for tests, if the tests take more than the given time in minutes, Github stops forcefully the workflow. By default, it is **30**.
- **RUN**: Whether to run all the inside workflows or not. This is useful when you want to skip checks since the code didn't change. By default, it is **true**.
- **RUN**: Whether to run all the jobs inside workflows or not. This is useful when you want to skip checks since the code didn't change. By default, it is **true**.
- **PROJECT**: The project to use when running npm scripts. If set, the executed npm script will be `{PROJECT}:{SCRIPT_NAME}` instead of `{SCRIPT_NAME}`.
- **RUN_ON**: the _label_ to select the correct _github-runner_ that will execute this workflow. Default is **zupit-agents**.
- **RUNNERS_CONTAINER_GROUP**: The runners group used to execute this workflow. Default is **Container**.
Expand Down Expand Up @@ -1108,7 +1108,7 @@ In addition, it is possible to specify this optional input:
- **RUN_ON**: the _label_ to select the correct _github-runner_ that will execute this workflow. Default is **zupit-agents**.
- **RUNNERS_CONTAINER_GROUP**: The runners group used to execute this workflow. Default is **Container**.
- **COVERAGE_ARTIFACT_NAME**: The artifact's name for the _coverage-django.xml_ file. By default, it is **coverage-django.xml**.
- **RUN**: Whether to run all the inside workflows or not. This is useful when you want to skip checks since the code didn't change. By default, it is **true**.
- **RUN**: Whether to run all the jobs inside workflows or not. This is useful when you want to skip checks since the code didn't change. By default, it is **true**.
- **DJANGO_MIGRATIONS_CHECK_APPS**: The Django apps on which to run migration checks.
- **SETUP_COMMANDS**: Allow to execute commands before the download of the dependencies. Useful to install packages required for Python dependencies.
- **ENABLE_LFS**: To enable Git LFS support on checkout
Expand Down Expand Up @@ -1212,7 +1212,7 @@ In addition, it is possible to specify this optional input:
default: 'Container'he path to Maven directory. By default, it is **./m2**.
- **EXTRA_MAVEN_ARGS**: Additional arguments for Maven. By default, it is **""**.
- **USE_CI_POSTGRES**: Whether to use Postgres for tests or not. If enabled, it injects the connection string to the DB for tests. By default, it is **true**.
- **RUN**: Whether to run all the inside workflows or not. This is useful when you want to skip checks since the code didn't change. By default, it is **true**.
- **RUN**: Whether to run all the jobs inside workflows or not. This is useful when you want to skip checks since the code didn't change. By default, it is **true**.
- **RUN_ON**: the _label_ to select the correct _github-runner_ that will execute this workflow. Default is **zupit-agents**.
- **RUNNERS_CONTAINER_GROUP**: The runners group used to execute this workflow. Default is **Container**.

Expand Down Expand Up @@ -1703,11 +1703,7 @@ jobs:

**conventional-commits-step-lint.yml** is the workflow that lint the commit messages of a pull request.

It requires these inputs:

- **CONFIG_FILE**: the config file name (by default it is **.commitlintrc**).

In addition, it is possible to specify this optional input:
It is possible to specify this optional input:

- **RUN_ON**: the _label_ to select the correct _github-runner_ that will execute this workflow. Default is **zupit-agents**.
- **RUNNERS_CONTAINER_GROUP**: The runners group used to execute this workflow. Default is **Container**.
Expand Down