-
-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
about_popup: Terminal size added in about popup. #1539
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
30f0424
about_popup: Terminal size added in about popup. Fixes #1536.
Swarnim114 6204d1f
about_popup: Modified test_pipups.py to test terminal size.
Swarnim114 48385e1
about_popup: Modified Terminal size text for readability.
Swarnim114 104eada
about_popup: Modified Terminal size text for readability.
Swarnim114 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1092,6 +1092,7 @@ def __init__( | |
notify_enabled: bool, | ||
exit_confirmation_enabled: bool, | ||
transparency_enabled: bool, | ||
terminal_size: Tuple[int, int], | ||
) -> None: | ||
self.feature_level_content = ( | ||
[("Feature level", str(server_feature_level))] | ||
|
@@ -1119,7 +1120,14 @@ def __init__( | |
), | ||
( | ||
"Detected Environment", | ||
[("Platform", PLATFORM), ("Python", detected_python_in_full())], | ||
[ | ||
("Platform", PLATFORM), | ||
("Python", detected_python_in_full()), | ||
( | ||
"Current terminal size", | ||
f"{terminal_size[0]} columns x {terminal_size[1]} rows", | ||
), | ||
], | ||
), | ||
] | ||
|
||
|
@@ -1137,7 +1145,6 @@ def __init__( | |
|
||
popup_width, column_widths = self.calculate_table_widths(contents, len(title)) | ||
widgets = self.make_table_with_categories(contents, column_widths) | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please check your PRs for these unrelated changes. |
||
super().__init__(controller, widgets, "ABOUT", popup_width, title) | ||
|
||
def keypress(self, size: urwid_Size, key: str) -> str: | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new code is not necessary:
mocker
/mock
/Mock()
is used for, if you intend to use it :)self.about_view
is set automatically in the first function (fixture) of this test class, which is used automatically every time, so this is duplicated each time.