-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bottom bar for navigation, tabs for inbox #578
Conversation
Great work on this pull request, Chrisirhc! |
Thanks @chrisirhc for exploring this and sending the PR! We've more recently gotten around to thinking through what we want the navigation to look like, and I just wrote down a proper spec for it: It overlaps with what this PR did, so I've added a link there saying this may be a useful starting point.
Yeah, deep links would be a useful feature but are tricky. Previous discussion here: |
I'm currently just fiddling around and looking and what maybe needs to be refactored around to get a similar navigation as the current Zulip app.
At this stage, the PR is a set of minimal changes to make it look/feel closer to a slightly more polished navigation.
So far some findings:
https://open.zulip.app/<serverIdentifier>/<path on zulip server>
Screen_recording_20240326_215102.webm
Note that the animations between the different navigation routes for the bottom navigation bar is slightly incorrect, since it uses a push animation that applies to the entire page including the navigation bar, rather than only animating/transitioning the main body area that's being changed.
Partially addresses #311