Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added about zulip option to main menu #1146

Closed
wants to merge 3 commits into from

Conversation

tomlin7
Copy link

@tomlin7 tomlin7 commented Dec 12, 2024

fix: #1128

Changes

  • Added About Zulip option to main menu

@chrisbobbe
Copy link
Collaborator

This will need to follow our Git style before it gets a review from a core team member. It also needs tests and localization.

@tomlin7
Copy link
Author

tomlin7 commented Dec 13, 2024

@chrisbobbe I have added localization and tests for the "about zulip" menu button.

I have noticed the commit messages, not to make any further mess here I will open a fresh new PR for this.

@tomlin7 tomlin7 closed this Dec 13, 2024
@tomlin7 tomlin7 deleted the about-zulip-menuoption branch December 13, 2024 21:25
@chrisbobbe
Copy link
Collaborator

Please don't open a fresh new PR for the same work; that's not necessary. Just force-push to the same branch: https://zulip.readthedocs.io/en/latest/git/using.html

@tomlin7
Copy link
Author

tomlin7 commented Dec 13, 2024

@chrisbobbe sure, I will keep that in mind. But #1157 has already been opened for this; please check.

@chrisbobbe
Copy link
Collaborator

But #1146 has already been opened for this

I think you mean #1157? (This issue is #1146.)

@tomlin7
Copy link
Author

tomlin7 commented Dec 13, 2024

@chrisbobbe my bad! pardon, I was a bit nervous about git rebase, and yes that is the correct PR #1157.

I have found this page really helpful: https://zulip.readthedocs.io/en/latest/git/fixing-commits.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"About Zulip" in main menu
3 participants