content: Handle link previews #1049
Conversation
rajveermalviya
force-pushed
the
pr-content-link-previews
branch
from
abdec10 to
8fba3fe
Compare
rajveermalviya
added
the
maintainer review
| padding: const EdgeInsets.symmetric(horizontal: 5), | ||
| child: InsetShadowBox( | ||
| bottom: 8, | ||
| color: messageListTheme.streamMessageBgDefault, |
There was a problem hiding this comment.
This looks like it'll be wrong for DMs, and (in future) for messages where we highlight the background because of @-mentions in the message (#647).
lib/widgets/content.dart
Outdated
| child: Text(node.title!, | ||
| style: TextStyle( | ||
| fontSize: 1.2 * kBaseFontSize, | ||
| color: const HSLColor.fromAHSL(1, 200, 1, 0.4).toColor()))), |
There was a problem hiding this comment.
I see a hard-coded color; does it follow web? It needs either a variable in ContentTheme or this comment:
// Web has the same color in light and dark mode.(Same for any other hard-coded colors.)
Please also post screenshots in light mode; I see screenshots for dark mode already.
There was a problem hiding this comment.
Updated the screenshots.
lib/widgets/content.dart
Outdated
| if (isSmallWidth) { | ||
| return Container( | ||
| decoration: const BoxDecoration(border: | ||
| Border(left: BorderSide(color: Color(0xFFEDEDED), width: 3))), |
There was a problem hiding this comment.
Same comment about hard-coded colors; also, I think we more often use lowercase (so 0xffededed instead of 0xFFEDEDED); here and below.
lib/widgets/content.dart
Outdated
| final messageListTheme = MessageListTheme.of(context); | ||
| final isSmallWidth = MediaQuery.sizeOf(context).width <= 576; | ||
|
|
||
| final dataContainer = Container( |
There was a problem hiding this comment.
Is dataContainer the best name? I see the Container widget being used…what's the "data" and how does that widget "contain" it?
How about building this method's return value with help from a mutable Widget result variable? So here:
Widget result = Container(/* etc. */);
then below,
result = isSmallWidth
? Column(/* etc. */, children: [/* etc. */, result])
: Row(/* etc. */, children: [/* etc. */, result]);then result = Container(decoration: /* etc. */, child: result);
and finally return result;.
rajveermalviya
force-pushed
the
pr-content-link-previews
branch
2 times, most recently
from
5b7b364 to
533fa33
Compare
rajveermalviya
force-pushed
the
pr-content-link-previews
branch
from
533fa33 to
aeabbe6
Compare
|
Thanks for the initial comments @chrisbobbe! Pushed a new revision, PTAL. |
Fixes: #1016
Screenshots