Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message list on subscribe/unsubscribe events #821

Open
gnprice opened this issue Jul 17, 2024 · 0 comments
Open

Update message list on subscribe/unsubscribe events #821

gnprice opened this issue Jul 17, 2024 · 0 comments
Labels
a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content

Comments

@gnprice
Copy link
Member

gnprice commented Jul 17, 2024

If the user unsubscribes from a channel/stream, then the combined feed will start treating the channel as muted. We should therefore update the message list when a SubscriptionRemoveEvent comes in (unless the channel was already muted), similar to what's called for on UserTopicEvent in #421.

Similarly in the reverse direction, on a SubscriptionAddEvent.

I'm giving this a late milestone because this isn't a situation users are likely to frequently see. It's not super frequent in the first place to subscribe or unsubscribe from a channel; and, crucially, there isn't any UI to do so on the combined-feed message list itself. So unlike #421 this isn't part of making the screen around any given piece of UI responsive to the user's actions on that UI.

Originally pointed out by @chrisbobbe at #421 (comment).

@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-model Implementing our data model (PerAccountStore, etc.) labels Jul 17, 2024
@gnprice gnprice added this to the Post-launch milestone Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content
Projects
Status: No status
Development

No branches or pull requests

1 participant