-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update message list on muting/unmuting a stream or topic #421
Comments
Unsubscribing from a stream means clearing out its mute state ( I don't think it's possible for a stream to be muted at the time you subscribe to it; i.e., the subscription has |
Yeah, seems right. Filed that as #821. |
In particular this will allow us to start offering UI for muting and unmuting topics, and have the message list the user is looking at update appropriately when they do so. Fixes: zulip#421
In particular this will allow us to start offering UI for muting and unmuting topics, and have the message list the user is looking at update appropriately when they do so. Fixes: zulip#421
In particular this will allow us to start offering UI for muting and unmuting topics, and have the message list the user is looking at update appropriately when they do so. Fixes: zulip#421
In my first implementation of stream and topic muting #346, I intend to leave in place one missing form of event update: if you have a message list you're already looking at (or already on the navigation stack), and then you mute or unmute a stream or topic so that it should cause some messages to disappear or appear in that message list, it won't notice that it should update.
This isn't fundamentally hard — just requires a bit of wiring up of the information — but it'll be a little bit of refactoring, and there's already enough refactoring going on in my draft for #346 that I'd like to keep the complexity down for now.
We don't yet offer UI within the app for muting or unmuting streams and topics (that's #347 and #348), so it won't currently be easy to actually run into this issue.
The text was updated successfully, but these errors were encountered: