Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update message list on muting/unmuting a stream or topic #421

Closed
gnprice opened this issue Nov 28, 2023 · 2 comments · Fixed by #822
Closed

Update message list on muting/unmuting a stream or topic #421

gnprice opened this issue Nov 28, 2023 · 2 comments · Fixed by #822
Assignees
Labels
a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content

Comments

@gnprice
Copy link
Member

gnprice commented Nov 28, 2023

In my first implementation of stream and topic muting #346, I intend to leave in place one missing form of event update: if you have a message list you're already looking at (or already on the navigation stack), and then you mute or unmute a stream or topic so that it should cause some messages to disappear or appear in that message list, it won't notice that it should update.

This isn't fundamentally hard — just requires a bit of wiring up of the information — but it'll be a little bit of refactoring, and there's already enough refactoring going on in my draft for #346 that I'd like to keep the complexity down for now.

We don't yet offer UI within the app for muting or unmuting streams and topics (that's #347 and #348), so it won't currently be easy to actually run into this issue.

@gnprice gnprice added a-msglist The message-list screen, except what's label:a-content a-model Implementing our data model (PerAccountStore, etc.) labels Nov 28, 2023
@gnprice gnprice added this to the Beta 2 milestone Nov 28, 2023
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Nov 29, 2023
This is the last step for implementing stream and topic muting,
i.e. zulip#346.  (Except for what's been split off to follow-up issues,
notably zulip#421.)

Fixes: zulip#346
@chrisbobbe
Copy link
Collaborator

Unsubscribing from a stream means clearing out its mute state (isMuted is stored on the subscription). I wonder if that means message lists should also sometimes update on SubscriptionRemoveEvents.

I don't think it's possible for a stream to be muted at the time you subscribe to it; i.e., the subscription has isMuted: true in the SubscriptionAddEvent. But if it is, we should handle that too.

gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 19, 2023
This is the last step for implementing stream and topic muting,
i.e. zulip#346.  (Except for what's been split off to follow-up issues,
notably zulip#421.)

Fixes: zulip#346
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Dec 19, 2023
This is the last step for implementing stream and topic muting,
i.e. zulip#346.  (Except for what's been split off to follow-up issues,
notably zulip#421.)

Fixes: zulip#346
gnprice added a commit that referenced this issue Dec 20, 2023
This is the last step for implementing stream and topic muting,
i.e. #346.  (Except for what's been split off to follow-up issues,
notably #421.)

Fixes: #346
@gnprice gnprice self-assigned this Jun 28, 2024
@gnprice
Copy link
Member Author

gnprice commented Jul 17, 2024

I wonder if that means message lists should also sometimes update on SubscriptionRemoveEvents.

Yeah, seems right. Filed that as #821.

gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jul 17, 2024
In particular this will allow us to start offering UI for muting
and unmuting topics, and have the message list the user is looking at
update appropriately when they do so.

Fixes: zulip#421
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Jul 24, 2024
In particular this will allow us to start offering UI for muting
and unmuting topics, and have the message list the user is looking at
update appropriately when they do so.

Fixes: zulip#421
gnprice added a commit to gnprice/zulip-flutter that referenced this issue Aug 9, 2024
In particular this will allow us to start offering UI for muting
and unmuting topics, and have the message list the user is looking at
update appropriately when they do so.

Fixes: zulip#421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-model Implementing our data model (PerAccountStore, etc.) a-msglist The message-list screen, except what's label:a-content
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants