Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"About Zulip" in main menu #1128

Closed
gnprice opened this issue Dec 11, 2024 · 4 comments · Fixed by #1157
Closed

"About Zulip" in main menu #1128

gnprice opened this issue Dec 11, 2024 · 4 comments · Fixed by #1157
Assignees
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Dec 11, 2024

The choose-account page has a menu with one item, "About Zulip", taking you to a page with that title. That page in turn has the version of the Zulip app, and an option to see the list of licenses for various open-source software used in the app.

Now that we have (after #1035 / #1076) a new overall navigation scheme, we should also add an "About Zulip" option in the main menu. That seems a more natural place for people to find it.

(It should also remain available in its existing location on the choose-account page. That ensures it's always possible to reach, even in a scenario where you can't get to the home page because the data can't be loaded from the server.)

Reported in a chat thread.

@Spyyy004
Copy link

Hey, I would love to work on this. Do you guys assign issues or i can start working straightaway?

@chrisbobbe
Copy link
Collaborator

@Spyyy004
Copy link

Hey, By main menu do you mean this section?
Screenshot 2024-12-12 at 17 27 22

@tomlin7
Copy link
Contributor

tomlin7 commented Dec 12, 2024

Hey I have worked on this feature and have added an About Zulip button to the main menu of the app, proceeding to open a PR on this.

tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 13, 2024
This is an implementation for issue zulip#1128

This commit includes localizations and tests for the button as well.
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 13, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 18, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 18, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 18, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 18, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 18, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 19, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 19, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 19, 2024
tomlin7 added a commit to tomlin7/zulip-flutter that referenced this issue Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants