Skip to content

Commit

Permalink
test [nfc]: Explain why a helper can't use addTearDown
Browse files Browse the repository at this point in the history
This follows up on this discussion:
  #590 (comment)
  • Loading branch information
gnprice committed Mar 27, 2024
1 parent 919cf12 commit 68116a2
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test/widgets/content_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ import 'page_checks.dart';
///
/// The caller must set [debugNetworkImageHttpClientProvider] back to null
/// before the end of the test.
// TODO(upstream) simplify callers by using addTearDown: https://github.com/flutter/flutter/issues/123189
// See also: https://github.com/flutter/flutter/issues/121917
FakeImageHttpClient prepareBoringImageHttpClient() {
final httpClient = FakeImageHttpClient();
debugNetworkImageHttpClientProvider = () => httpClient;
Expand Down

0 comments on commit 68116a2

Please sign in to comment.