msglist [nfc]: Return early if generation has changed

Signed-off-by: Zixuan James Li <[email protected]>
zulip · Nov 12, 2024 · 67fbf9e · 67fbf9e
1 parent e9a8dd6
commit 67fbf9e
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/model/message_list.dart b/lib/model/message_list.dart
@@ -530,11 +530,13 @@ class MessageListView with ChangeNotifier, _MessageSequence {
       _insertAllMessages(0, fetchedMessages);
       _haveOldest = result.foundOldest;
     } finally {
-      if (this.generation == generation) {
-        _fetchingOlder = false;
-        _updateEndMarkers();
-        notifyListeners();
+      if (this.generation != generation) {
+        // ignore: control_flow_in_finally
+        return;
       }
+      _fetchingOlder = false;
+      _updateEndMarkers();
+      notifyListeners();
     }
   }